On Sat, Apr 10, 2010 at 12:36 PM, Keith Whitwell <keith.whitw...@googlemail.com> wrote: > On Sat, Apr 10, 2010 at 6:59 AM, Chia-I Wu <olva...@gmail.com> wrote: >> On Fri, Apr 9, 2010 at 9:07 PM, Keith Whitwell <kei...@vmware.com> wrote: >>> On Fri, 2010-04-09 at 03:43 -0700, Keith Whitwell wrote: >>>> On Thu, 2010-04-08 at 15:20 -0700, Marek Olšák wrote: >>>> > On Thu, Apr 8, 2010 at 3:54 PM, Keith Whitwell <kei...@vmware.com> >>>> > wrote: >>>> > >>>> > OK, it seems like quite a few cases had migrated to the new >>>> > >>>> > buffer_map_range() behaviour. I've looked at all I can find >>>> > and moved >>>> > them back to the old behaviour. >>>> > >>>> > glean is passing now on softpipe. >>>> > >>>> > There's now an assertion failure in pipe_buffer_flush_mapped_range. >>>> > Given a mapped range, the current behavior in debug build doesn't >>>> > allow to flush its subrange if it doesn't touch the last byte of the >>>> > range. The attached patch fixes that and changes u_uploadmgr for the >>>> > mapped and flushed ranges to match. Please review. >>>> > >>>> > Other than that, it's stable as master. Thank you very much. >>>> >>>> OK, if nobody chimes in, let's look at merging this to master in the >>>> next day or so. >>>> >>> >>> I've made a final merge of master into gallium-resources. Please try it >>> out and report/fix any issues. This will be merged tomorrow. >> Texturing in i915g seems to be broken. You can find screenshots of drawpix >> and >> teapot in the attachments. Any idea? >> > > Looks like only the first row of texels is being uploaded. > > Maybe stride is being set to zero in the transfer creation, or similar?
Hmm, yes - u_default_get_transfer doesn't fill stride in, which is fine for buffers but busted for textures. I'll modify the two places where this is being used for textures. Keith ------------------------------------------------------------------------------ Download Intel® Parallel Studio Eval Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta. http://p.sf.net/sfu/intel-sw-dev _______________________________________________ Mesa3d-dev mailing list Mesa3d-dev@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mesa3d-dev
