On Fri, Jul 16, 2010 at 7:59 AM, Sedat Dilek <sedat.di...@googlemail.com> wrote: > On Fri, Jul 16, 2010 at 1:43 PM, Chia-I Wu <olva...@gmail.com> wrote: >> On Wed, Jul 14, 2010 at 1:53 AM, Sedat Dilek <sedat.di...@googlemail.com> >> wrote: >>> On Tue, Jul 13, 2010 at 5:25 PM, Sedat Dilek <sedat.di...@googlemail.com> >>> wrote: >>> [...] >>>> Shouldn't there be a more rough depend-checking on XCB_DRI2 >>>> (libxcb-1.6) in configure.ac? >>>> With "rough" I mean to stop immediately the build, so someone can >>>> check for the missing packages. >>>> >>> >>> Looking at [1] feom >>> >>> Commit 2168b87b51e70e8ad914e547c6c922fc33af3a89 >>> "egl_dri2: Support _EGL_PLATFORM_DRM" >>> >>> [configure.ac] >>> ... >>> # build egl_dri2 when xcb-dri2 is available >>> - PKG_CHECK_MODULES([EGL_DRI2], [x11-xcb xcb-dri2 xcb-xfixes libdrm], >>> + PKG_CHECK_MODULES([XCB_DRI2], [x11-xcb xcb-dri2 xcb-xfixes], >>> [have_xcb_dri2=yes],[have_xcb_dri2=no]) >>> + PKG_CHECK_MODULES([LIBUDEV], [libudev > 150], >>> + [have_libudev=yes],[have_libudev=no]) >>> + >>> if test "$have_xcb_dri2" = yes; then >>> - EGL_DRIVERS_DIRS="$EGL_DRIVERS_DIRS dri2" >>> + EGL_DRIVER_DRI2=dri2 >>> + DEFINES="$DEFINES -DHAVE_XCB_DRI2" >>> + fi >>> + >>> + if test "$have_libudev" = yes; then >>> + EGL_DRIVER_DRI2=dri2 >>> + DEFINES="$DEFINES -DHAVE_LIBUDEV" >>> fi >>> + >>> + EGL_DRIVERS_DIRS="$EGL_DRIVERS_DIRS $EGL_DRIVER_DRI2" >>> ... >>> >>> So if $have_xcb_dri2 is false, but $have_libudev true, >>> $EGL_DRIVER_DRI2 is set to "dri2" and the compilation of egl_dri2 will >>> be broken. >>> >>> What about...? >>> >>> - EGL_DRIVERS_DIRS="$EGL_DRIVERS_DIRS $EGL_DRIVER_DRI2" >>> + if test "$have_xcb_dri2" = no; then >>> + EGL_DRIVERS_DIRS="$EGL_DRIVERS_DIRS" >>> + else >>> + EGL_DRIVERS_DIRS="$EGL_DRIVERS_DIRS $EGL_DRIVER_DRI2" >>> + fi >>> >>> - Sedat - >>> >>> [1] >>> http://cgit.freedesktop.org/mesa/mesa/diff/configure.ac?id=2168b87b51e70e8ad914e547c6c922fc33af3a89 >> I will commit a fix so that egl_dri2 is built only when xcb-dri2 is >> available. >> I believe Krisitian wants to make xcb-dri2 optional, but it does not seem to >> be >> the case right now. >> >> >> -- >> o...@lunarg.com >> > > Sounds good to me, thanks for your attention.
Yup, sounds fine, thanks Chia-I. Kristian ------------------------------------------------------------------------------ This SF.net email is sponsored by Sprint What will you do first with EVO, the first 4G phone? Visit sprint.com/first -- http://p.sf.net/sfu/sprint-com-first _______________________________________________ Mesa3d-dev mailing list Mesa3d-dev@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mesa3d-dev
