[
https://issues.apache.org/jira/browse/MESOS-37?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13147552#comment-13147552
]
[email protected] commented on MESOS-37:
----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2663/#review3152
-----------------------------------------------------------
Ship it!
Looks great, thanks Charles!
- Andy
On 2011-11-02 23:16:55, Charles Reiss wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2663/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-11-02 23:16:55)
bq.
bq.
bq. Review request for mesos.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Currently, tests/process_spawn.cpp uses INT_MAX but only includes
<iostream> which is not gaurenteed (and apparently does not on some systems) to
define INT_MAX, causing a compilation error.
bq.
bq.
bq. This addresses bug MESOS-37.
bq. https://issues.apache.org/jira/browse/MESOS-37
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/tests/process_spawn.cpp 4f60296
bq.
bq. Diff: https://reviews.apache.org/r/2663/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Charles
bq.
bq.
> Compilation broken on Ubuntu Lucid (twitter branch)
> ---------------------------------------------------
>
> Key: MESOS-37
> URL: https://issues.apache.org/jira/browse/MESOS-37
> Project: Mesos
> Issue Type: Bug
> Reporter: Michael Armbrust
> Priority: Blocker
> Attachments:
> 0001-include-limits.h-in-process_spawn-to-fix-compilati.patch, MESOS-37.patch
>
>
> The first problem is as follows:
> WAR [20111013-16:53:27.595] deploylib: /bin/sh: pushd: not found
> WAR [20111013-16:53:27.595] deploylib: python2.6: can't open file 'setup.py':
> [Errno 2] No such file or directory
> WAR [20111013-16:53:27.595] deploylib: /bin/sh: popd: not found
> WAR [20111013-16:53:27.595] deploylib: make[1]: *** [../lib/python/mesos.py]
> Error 127
> WAR [20111013-16:53:27.595] deploylib: make: *** [src] Error 2
> WAR [20111013-16:53:27.595] deploylib: install: cannot stat
> `./bin/killtree.sh': No such file or directory
> WAR [20111013-16:53:27.595] deploylib: make: *** [install] Error 1
> I was able to work around this issue by running "rm /bin/sh; ln -s /bin/bash
> /bin/sh". However then I ran into this issue:
> g++ -o ../../bin/tests/process_spawn process_spawn.cpp
> process_spawn.cpp: In function 'void dummywait()':
> process_spawn.cpp:16: error: 'getchar' was not declared in this scope
> process_spawn.cpp:16: error: 'EOF' was not declared in this scope
> process_spawn.cpp:17: error: 'INT_MAX' was not declared in this scope
> make[2]: *** [../../bin/tests/process_spawn] Error 1
> make[2]: Leaving directory `/home/ubuntu/mesos/src/tests'
> make[1]: *** [all] Error 2
> make[1]: Leaving directory `/home/ubuntu/mesos/src'
> make: *** [src] Error 2
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
