[
https://issues.apache.org/jira/browse/MESOS-79?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13149258#comment-13149258
]
[email protected] commented on MESOS-79:
----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2816/#review3189
-----------------------------------------------------------
Ship it!
Looks great. I've tested this and it works.
- Andy
On 2011-11-12 08:49:35, Charles Reiss wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2816/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-11-12 08:49:35)
bq.
bq.
bq. Review request for mesos.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Calls sys.exit() with the result of SchedulerDriver.run() rather than
ignoring the return value. Relies on 0 being the 'OK' status code.
bq.
bq.
bq. This addresses bug MESOS-79.
bq. https://issues.apache.org/jira/browse/MESOS-79
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/examples/python/test_framework.py 0e4b14c
bq.
bq. Diff: https://reviews.apache.org/r/2816/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Charles
bq.
bq.
> Python external test doesn't actually test that framework finished cleanly
> --------------------------------------------------------------------------
>
> Key: MESOS-79
> URL: https://issues.apache.org/jira/browse/MESOS-79
> Project: Mesos
> Issue Type: Bug
> Components: python-api, test
> Reporter: Charles Reiss
> Assignee: Charles Reiss
> Priority: Trivial
> Labels: python
>
> The Python example framework doesn't check the status returned by
> SchedulerDriver.run(), so if, for example, the framework is aborted, it will
> exit normally. The PythonFramework external test will interpret this normal
> exit as success when it should be a failure.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
