----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2818/#review3190 -----------------------------------------------------------
src/Makefile.in <https://reviews.apache.org/r/2818/#comment7053> ; should be && so the make target always fails if the directory doesn't exist. - Charles On 2011-11-13 09:00:41, Andy Konwinski wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/2818/ > ----------------------------------------------------------- > > (Updated 2011-11-13 09:00:41) > > > Review request for mesos and Charles Reiss. > > > Summary > ------- > > Fixes a problem that was causing the protocol buffer python egg not to get > built on ubuntu linux. > > > This addresses bug MESOS-63. > https://issues.apache.org/jira/browse/MESOS-63 > > > Diffs > ----- > > Makefile.in 0d2bf7c > src/Makefile.in a81aacb > > Diff: https://reviews.apache.org/r/2818/diff > > > Testing > ------- > > I'm uploading a very small patch that makes these changes. I've tested it on > Ubuntu 10.04.3 LTS, OSX Snow Leopard, and Debian GNU/Linux 5.0. > > The tests run and pass on OSX and Ubuntu. The > SampleFrameworks.PythonFramework test fails on Debian, but when I apply > MESOS-78 and MESOS-79, the tests all pass on Debian too. > > > Thanks, > > Andy > >
