----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2763/#review3414 -----------------------------------------------------------
src/master/constants.hpp <https://reviews.apache.org/r/2763/#comment7643> This should probably default to 1000 instead of 100, but I'm assuming that Task objects are relatively small so the master could hold 100,000's (i.e. 1000 each for 100's of FWs) of them in memory without worrying too much. Also, since its semantics are slightly different than the other constant you added, please give it a more descriptive name like MAX_COMPLETED_TASKS_PER_FRAMEWORK src/master/master.cpp <https://reviews.apache.org/r/2763/#comment7649> I don't think you need this temporary variable here. Just do push_back(*framework). - Andy On 2011-11-15 00:59:14, Thomas Marshall wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/2763/ > ----------------------------------------------------------- > > (Updated 2011-11-15 00:59:14) > > > Review request for mesos and Andy Konwinski. > > > Summary > ------- > > Frameworks are no longer deleted when they are done executing; they are saved > in a list in the master, which is then displayed on the webui. Tasks are > similarly stored in their framework. > > > This addresses bug MESOS-8. > https://issues.apache.org/jira/browse/MESOS-8 > > > Diffs > ----- > > src/webui/master/index.tpl 16e3446 > src/master/constants.hpp db82177 > src/master/http.cpp 47caf48 > src/master/master.hpp fdacf36 > src/master/master.cpp b6cfde7 > src/webui/master/framework.tpl 0f41349 > > Diff: https://reviews.apache.org/r/2763/diff > > > Testing > ------- > > > Thanks, > > Thomas > >
