[
https://issues.apache.org/jira/browse/MESOS-89?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13164700#comment-13164700
]
[email protected] commented on MESOS-89:
----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3050/#review3712
-----------------------------------------------------------
src/Makefile.in
<https://reviews.apache.org/r/3050/#comment8323>
MONITORING_OBJ should be set to empty string unconditionally first.
src/monitoring/proc_utils.hpp
<https://reviews.apache.org/r/3050/#comment8319>
Why strings? (and elsewhere)
src/monitoring/proc_utils.hpp
<https://reviews.apache.org/r/3050/#comment8309>
Why milliseconds? libprocess uses seconds since some time, and I think
USER_HZ usually (often?) isn't 1000.
src/monitoring/proc_utils.hpp
<https://reviews.apache.org/r/3050/#comment8320>
Please state whether RSS or VSIZE or something else.
src/monitoring/proc_utils.cpp
<https://reviews.apache.org/r/3050/#comment8316>
include all system .h headers either before or after standard C++ headers.
src/monitoring/proc_utils.cpp
<https://reviews.apache.org/r/3050/#comment8315>
Please make these file-scoped (static or anonymous namespace) or put them
in the header file.
src/monitoring/proc_utils.cpp
<https://reviews.apache.org/r/3050/#comment8311>
O is a pretty bad variable name.
src/monitoring/proc_utils.cpp
<https://reviews.apache.org/r/3050/#comment8313>
Check whether this read succeeds.
- Charles
On 2011-12-07 07:08:06, Alex Degtiar wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3050/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-12-07 07:08:06)
bq.
bq.
bq. Review request for mesos.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. The first of several patches related to resource usage monitoring. This
patch provides a collection of utilities for use on Linux for reading stats
from proc. It is used by both the lxc and proc resource collectors.
bq.
bq.
bq. This addresses bug MESOS-89.
bq. https://issues.apache.org/jira/browse/MESOS-89
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/tests/Makefile.in ea943f7
bq. src/tests/proc_utils_tests.cpp PRE-CREATION
bq. src/Makefile.in 516f128
bq. src/monitoring/proc_utils.hpp PRE-CREATION
bq. src/monitoring/proc_utils.cpp PRE-CREATION
bq.
bq. Diff: https://reviews.apache.org/r/3050/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Sanity tests have been written in src/tests/proc_utils_tests.cpp for all
utility functions, and functions have been tested ad hoc.
bq.
bq.
bq. Thanks,
bq.
bq. Alex
bq.
bq.
> create utilities to collect information from the proc filesystem
> ----------------------------------------------------------------
>
> Key: MESOS-89
> URL: https://issues.apache.org/jira/browse/MESOS-89
> Project: Mesos
> Issue Type: Sub-task
> Components: slave
> Environment: This is specific to Linux, as OS X does not have a proc
> filesystem.
> Reporter: Sam Whitlock
> Assignee: Alex Degtiar
> Priority: Minor
> Labels: monitoring
>
> This is a utility for MESOS-38 https://issues.apache.org/jira/browse/MESOS-38
> Create a collection of utilities to read information from the proc
> filesystem. This will be used in MESOS-38 to collect most of the information
> for the process-based isolation usage reporting mechanism. These utilities
> will also be used for certain functionality in monitoring lxc-based isolation
> because not all of the information needed is available via the cgroup
> interface, such as the start time of the container.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
