> On 2012-01-24 02:38:37, Benjamin Hindman wrote: > > Makefile.am, line 51 > > <https://reviews.apache.org/r/3579/diff/3/?file=70239#file70239line51> > > > > Please move this up to line 42.
Done. > On 2012-01-24 02:38:37, Benjamin Hindman wrote: > > src/Makefile.am, line 266 > > <https://reviews.apache.org/r/3579/diff/3/?file=70240#file70240line266> > > > > Wait, shouldn't that be libprotobuf.la? Probably. (But I'd prefer this fix in a separate commit.) > On 2012-01-24 02:38:37, Benjamin Hindman wrote: > > src/Makefile.am, line 361 > > <https://reviews.apache.org/r/3579/diff/3/?file=70240#file70240line361> > > > > Awesome, but let's move this comment and the Mesos JAR* stuff above the > > protobuf stuff (outside the 'if HAS_JAVA') and then only have a single if > > HAS_JAVA block here. Done. > On 2012-01-24 02:38:37, Benjamin Hindman wrote: > > src/Makefile.am, line 368 > > <https://reviews.apache.org/r/3579/diff/3/?file=70240#file70240line368> > > > > No need to start with the empty line. Compacted. > On 2012-01-24 02:38:37, Benjamin Hindman wrote: > > src/Makefile.am, line 492 > > <https://reviews.apache.org/r/3579/diff/3/?file=70240#file70240line492> > > > > Add small comment about this as you did with the Java stuff above. Done. - Charles ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3579/#review4545 ----------------------------------------------------------- On 2012-01-24 09:02:16, Charles Reiss wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3579/ > ----------------------------------------------------------- > > (Updated 2012-01-24 09:02:16) > > > Review request for mesos. > > > Summary > ------- > > Add some missing files in src/ and include/ to distribution and makes header > files be installed (under $(pkgincludedir) = $(includedir)/mesos = > $(prefix)/include/mesos by default). > > > This addresses bugs MESOS-119 and MESOS-120. > https://issues.apache.org/jira/browse/MESOS-119 > https://issues.apache.org/jira/browse/MESOS-120 > > > Diffs > ----- > > Makefile.am f26e555 > src/Makefile.am b8fc58e > > Diff: https://reviews.apache.org/r/3579/diff > > > Testing > ------- > > > Thanks, > > Charles > >
