[
https://issues.apache.org/jira/browse/MESOS-120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13193523#comment-13193523
]
[email protected] commented on MESOS-120:
-----------------------------------------------------
bq. On 2012-01-24 21:23:29, Benjamin Hindman wrote:
bq. > src/Makefile.am, line 387
bq. > <https://reviews.apache.org/r/3587/diff/1/?file=70255#file70255line387>
bq. >
bq. > If we don't build with java, does 'make clean' complain if these
don't exist? What's the cons to sticking all the clean stuff (including the
clean-java/clean-python) targets within 'if HAS_JAVA' (or 'if HAS_PYTHON')?
bq.
bq. Charles Reiss wrote:
bq. make clean needs to work even if you didn't build, so it shouldn't.
bq.
bq. Benjamin Hindman wrote:
bq. If we need 'clean-java' to be outside of the 'if HAS_JAVA' block, then
I think it should be at the bottom of that block to make it easier to
understand. Likewise, we can put CLEANFILES for MESOS_JAR and EXAMPLES_JAR
inside the if HAS_JAVA block next to their targets (in fact, I think MESOS_JAR
was already there, but not by itself). Likewise, I'd like to move the
clean-python one too.
Moved clean-java and clean-python blocks to after the HAS_* blocks, and
CLEANFILES additions to the HAS_* blocks.
- Charles
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3587/#review4561
-----------------------------------------------------------
On 2012-01-26 02:23:30, Charles Reiss wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3587/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-01-26 02:23:30)
bq.
bq.
bq. Review request for mesos.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. 'make clean' is currently missing a few generated files; this adds them.
bq.
bq. Also makes mesos_pb2.py be generated directly in python/src instead of
being copied there.
bq.
bq. Part of MESOS-120 because this is necessary for 'make distcheck' to pass.
bq.
bq.
bq. This addresses bug MESOS-120.
bq. https://issues.apache.org/jira/browse/MESOS-120
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/Makefile.am 48727ae
bq.
bq. Diff: https://reviews.apache.org/r/3587/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Charles
bq.
bq.
> Get 'make dist' working correctly
> ---------------------------------
>
> Key: MESOS-120
> URL: https://issues.apache.org/jira/browse/MESOS-120
> Project: Mesos
> Issue Type: Sub-task
> Reporter: Benjamin Hindman
> Assignee: Charles Reiss
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
