[
https://issues.apache.org/jira/browse/MESOS-68?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13208637#comment-13208637
]
[email protected] commented on MESOS-68:
----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3872/#review5129
-----------------------------------------------------------
Ship it!
Thanks Charles. I'll check this in shortly.
- Benjamin
On 2012-02-12 00:04:59, Charles Reiss wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3872/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-02-12 00:04:59)
bq.
bq.
bq. Review request for mesos and Benjamin Hindman.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Note: For size, the patch does not include the zookeeper-3.3.4.tar.gz; it
will need to be acquired separately.
bq.
bq. This removes hard-coded version numbers from src/Makefile.am and
third_party/Makefile.am, moving them to a new third_party/versions.am file. It
removes hardcoded zookeeper version numbers in test code by passing the
zookeeper version in a -D compiler option.
bq.
bq. It also upgrades zookeeper from 3.3.1 to 3.3.4, which fixes
(warnings-related) build problems with recent GCCs.
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/Makefile.am f0806ab
bq. src/tests/base_zookeeper_test.cpp 83fcf35
bq. third_party/Makefile.am c0e8937
bq. third_party/versions.am PRE-CREATION
bq. third_party/zookeeper-3.3.1.tar.gz c67deed
bq. third_party/zookeeper-3.3.4.tar.gz PRE-CREATION
bq.
bq. Diff: https://reviews.apache.org/r/3872/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. make check
bq.
bq.
bq. Thanks,
bq.
bq. Charles
bq.
bq.
> compilation fails on Ubuntu 11.10 without the included zookeeper
> ----------------------------------------------------------------
>
> Key: MESOS-68
> URL: https://issues.apache.org/jira/browse/MESOS-68
> Project: Mesos
> Issue Type: Bug
> Environment: Ubuntu Oneric (11.10)
> Reporter: Sam Whitlock
> Priority: Minor
>
> When configured with the option --with-included-zookeeper, mesos does not
> compile.
> --- Relevant Make Output ---
> g++ -c -O2 -fno-strict-aliasing -fPIC -g -I. -I. -I../include -I../include
> -I../third_party/boost-1.37.0 -I../third_party/protobuf-2.3.0/src
> -I../third_party/glog-0.3.1/src -I../third_party/glog-0.3.1/src
> -I../third_party/leveldb/include -I../third_party/libprocess/include -MMD -MP
> -Ijava/jni -I/usr/lib/jvm/java-7-openjdk-amd64/include
> -I/usr/lib/jvm/java-7-openjdk-amd64/include/linux
> -I/usr/lib/jvm/java-7-openjdk-amd64/include/linux -o
> java/jni/org_apache_mesos_Log.o java/jni/org_apache_mesos_Log.cpp
> java/jni/org_apache_mesos_Log.cpp: In function 'void
> Java_org_apache_mesos_Log_initialize__ILjava_lang_String_2Ljava_lang_String_2JLjava_util_concurrent_TimeUnit_2Ljava_lang_String_2(JNIEnv*,
> jobject, jint, jstring, jstring, jlong, jobject, jstring)':
> java/jni/org_apache_mesos_Log.cpp:457:59: error: no matching function for
> call to 'mesos::internal::log::Log::Log(int&, std::string&, std::string&,
> seconds&, std::string&)'
> java/jni/org_apache_mesos_Log.cpp:457:59: note: candidates are:
> ./log/log.hpp:153:3: note: mesos::internal::log::Log::Log(int, const string&,
> const std::set<process::UPID>&)
> ./log/log.hpp:153:3: note: candidate expects 3 arguments, 5 provided
> ./log/log.hpp:25:7: note: mesos::internal::log::Log::Log(const
> mesos::internal::log::Log&)
> ./log/log.hpp:25:7: note: candidate expects 1 argument, 5 provided
> java/jni/org_apache_mesos_Log.cpp: In function 'void
> Java_org_apache_mesos_Log_initialize__ILjava_lang_String_2Ljava_lang_String_2JLjava_util_concurrent_TimeUnit_2Ljava_lang_String_2Ljava_lang_String_2_3B(JNIEnv*,
> jobject, jint, jstring, jstring, jlong, jobject, jstring, jstring,
> jbyteArray)':
> java/jni/org_apache_mesos_Log.cpp:512:5: error: 'zookeeper' has not been
> declared
> java/jni/org_apache_mesos_Log.cpp:512:31: error: expected ';' before 'auth'
> java/jni/org_apache_mesos_Log.cpp:513:5: error: 'auth' was not declared in
> this scope
> java/jni/org_apache_mesos_Log.cpp:518:56: error: no matching function for
> call to 'mesos::internal::log::Log::Log(int&, std::string&, std::string&,
> seconds&, std::string&)'
> java/jni/org_apache_mesos_Log.cpp:518:56: note: candidates are:
> ./log/log.hpp:153:3: note: mesos::internal::log::Log::Log(int, const string&,
> const std::set<process::UPID>&)
> ./log/log.hpp:153:3: note: candidate expects 3 arguments, 5 provided
> ./log/log.hpp:25:7: note: mesos::internal::log::Log::Log(const
> mesos::internal::log::Log&)
> ./log/log.hpp:25:7: note: candidate expects 1 argument, 5 provided
> make[1]: *** [java/jni/org_apache_mesos_Log.o] Error 1
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
