-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3963/#review5219
-----------------------------------------------------------


This patch will make things work assuming MESOS_HOME points to a built build 
directory. Since it only works for the uninstalled case. It would be ideal for 
us to handle the installed case, too. (You can examine the hierarchy created by 
make DESTDIR=...) I think we should also be aiming to migrate away from 
MESOS_HOME as the name of the env. var. to locate mesos binaries -- at least 
uninstalled ones because of source/build dir confusion. But that doesn't need 
to be done now. (Related bug: MESOS-85.)

Looks okay to me, otherwise.


- Charles


On 2012-02-20 05:47:25, Thomas Marshall wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3963/
> -----------------------------------------------------------
> 
> (Updated 2012-02-20 05:47:25)
> 
> 
> Review request for mesos, Benjamin Hindman and Charles Reiss.
> 
> 
> Summary
> -------
> 
> After the autotools update, some of the library files that Hadoop depended on 
> were moved, causing compilation to fail.
> 
> 
> This addresses bug MESOS-148.
>     https://issues.apache.org/jira/browse/MESOS-148
> 
> 
> Diffs
> -----
> 
>   frameworks/hadoop-0.20.2/bin/hadoop 51ba90f 
>   frameworks/hadoop-0.20.2/src/contrib/mesos/build.xml 6b53139 
>   
> frameworks/hadoop-0.20.2/src/contrib/mesos/src/java/org/apache/hadoop/mapred/FrameworkScheduler.java
>  43416cc 
> 
> Diff: https://reviews.apache.org/r/3963/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Thomas
> 
>

Reply via email to