[
https://issues.apache.org/jira/browse/MESOS-85?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13236325#comment-13236325
]
[email protected] commented on MESOS-85:
----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4434/#review6247
-----------------------------------------------------------
I do want to get this committed, but when I was looking a little closer there
are a few cleanups to make first.
src/common/logging.cpp
<https://reviews.apache.org/r/4434/#comment13503>
This all becomes:
return conf.get("log_dir", "");
Also, is it okay to return an empty log dir!?
src/configurator/configurator.hpp
<https://reviews.apache.org/r/4434/#comment13579>
As long as you're in this file, please kill these white spaces.
src/configurator/configurator.hpp
<https://reviews.apache.org/r/4434/#comment13580>
And here.
src/launcher/launcher.cpp
<https://reviews.apache.org/r/4434/#comment13504>
s/frameworksHome/configuration option 'frameworks_home'
src/launcher/launcher.cpp
<https://reviews.apache.org/r/4434/#comment13581>
Not your bug, but the '\' should not be necessary. Please kill them. Also,
s/MESOS_FRAMEWORKS_HOME/the configuration option 'frameworks_home'.
src/slave/slave.cpp
<https://reviews.apache.org/r/4434/#comment13582>
This all becomes:
string workDir = conf.get("work_dir", "work");
src/slave/webui.cpp
<https://reviews.apache.org/r/4434/#comment13506>
Same as above.
src/tests/configurator_tests.cpp
<https://reviews.apache.org/r/4434/#comment13584>
Kill whitespace.
src/tests/configurator_tests.cpp
<https://reviews.apache.org/r/4434/#comment13509>
Remove extra spaces.
- Benjamin
On 2012-03-21 19:02:07, Charles Reiss wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4434/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-03-21 19:02:07)
bq.
bq.
bq. Review request for mesos and Benjamin Hindman.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Removes most remaining uses of MESOS_HOME from the tree.
bq.
bq. Includes updates to the deploy scripts, but does not fix the deploy
scripts (since mesos-getconf still won't exist).
bq.
bq. After this patch, the remaining uses of MESOS_HOME I'm aware of are in the
EC2 scripts.
bq.
bq.
bq. This addresses bug MESOS-85.
bq. https://issues.apache.org/jira/browse/MESOS-85
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/tests/external_tests.cpp 21fa705
bq. src/slave/slave.cpp 9332caa
bq. src/slave/webui.cpp 9f45442
bq. src/tests/configurator_tests.cpp 662e01f
bq. src/sched/sched.cpp 16770a1
bq. src/slave/lxc_isolation_module.cpp 8c25dd4
bq. src/slave/main.cpp ac780c4
bq. src/slave/process_based_isolation_module.cpp e0f3ee8
bq. src/master/main.cpp a8fadc9
bq. src/mesos/main.cpp bbdb981
bq. src/launcher/main.cpp 5c55ace
bq. src/local/main.cpp d4b68a9
bq. src/launcher/launcher.cpp 98a4847
bq. src/launcher/launcher.hpp 221094f
bq. src/deploy/mesos-env.sh 9f93a41
bq. src/deploy/mesos-daemon 2e75d04
bq. src/configurator/configurator.hpp a3a104f
bq. src/configurator/configurator.cpp 2666e50
bq. src/common/logging.cpp 9e346f2
bq.
bq. Diff: https://reviews.apache.org/r/4434/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. make check
bq.
bq.
bq. Thanks,
bq.
bq. Charles
bq.
bq.
> Need to update semantics of MESOS_HOME
> --------------------------------------
>
> Key: MESOS-85
> URL: https://issues.apache.org/jira/browse/MESOS-85
> Project: Mesos
> Issue Type: Improvement
> Components: build, master, slave, test
> Reporter: Benjamin Hindman
> Assignee: Charles Reiss
> Priority: Critical
>
> Currently MESOS_HOME is getting used for too much stuff. It is used to
> represent where the slave should store it's "work" directory, where the slave
> expects "killtree" to be, where the master and slave should put logging,
> where the tests assume certain scripts live, etc. In practice this has meant
> that if mesos gets installed at /usr/local/mesos, then slave work directories
> go there, logs go there, etc, which is totally unacceptable.
> MESOS_HOME should either be eliminated, or it's semantics should be changed
> so that it only represents where binaries live, but not where things like
> work directories exist, logs go, etc. In addition, the testing infrastructure
> should get updated so that the external tests can find the scripts they need
> to run things *without* needing MESOS_HOME while still supporting a remote
> build directory.
> This issue is tagged as a blocker because in order to do the port to
> autotools cleanly, this really needs to get done in order to run the external
> tests.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
