[
https://issues.apache.org/jira/browse/MESOS-86?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13239133#comment-13239133
]
[email protected] commented on MESOS-86:
----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3083/#review6395
-----------------------------------------------------------
Ship it!
Thanks Vinod! I know Matei really wanted these in before the release so this is
great!
src/examples/java/TestExceptionFramework.java
<https://reviews.apache.org/r/3083/#comment13955>
Wrap.
src/examples/java/TestFramework.java
<https://reviews.apache.org/r/3083/#comment13956>
Wrap.
src/examples/java/TestMultipleExecutorsFramework.java
<https://reviews.apache.org/r/3083/#comment13957>
Wrap.
src/examples/long_lived_framework.cpp
<https://reviews.apache.org/r/3083/#comment13952>
Don't you want to reorganize these? ;) (And elsewhere.)
src/examples/no_executor_framework.cpp
<https://reviews.apache.org/r/3083/#comment13953>
Awesome!
src/java/jni/convert.cpp
<https://reviews.apache.org/r/3083/#comment13958>
Not used, please kill.
src/java/src/org/apache/mesos/Scheduler.java
<https://reviews.apache.org/r/3083/#comment13959>
Put on previous line.
src/python/native/proxy_scheduler.cpp
<https://reviews.apache.org/r/3083/#comment13960>
Ugh. ;)
src/python/native/proxy_scheduler.cpp
<https://reviews.apache.org/r/3083/#comment13961>
Indentation.
- Benjamin
On 2012-03-27 01:25:17, Vinod Kone wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3083/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-03-27 01:25:17)
bq.
bq.
bq. Review request for mesos, Benjamin Hindman and John Sirois.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. New Scheduler callbacks for master info (ip and port)
bq.
bq. --> registered() callback now includes maste info
bq. --> new re-registered() callback is called when a new master is elected
bq. --> new masterLost() callback is called when mesos core doesnt detect
an
bq. active master (e.g: during election)
bq. --> new executorLost() callback
bq.
bq. New Executor callbacks
bq. --> reregistered() callback
bq. --> slaveLost() callback
bq.
bq.
bq. This addresses bug MESOS-86.
bq. https://issues.apache.org/jira/browse/MESOS-86
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. include/mesos/executor.hpp ef7bdf9
bq. include/mesos/scheduler.hpp 5bcf065
bq. src/common/values.cpp 09d162f
bq. src/examples/java/TestExceptionFramework.java d15b132
bq. src/examples/java/TestFramework.java f86646b
bq. src/examples/java/TestMultipleExecutorsFramework.java cdbcc48
bq. src/examples/long_lived_executor.cpp 4b4abad
bq. src/examples/long_lived_framework.cpp 2775f5a
bq. src/examples/no_executor_framework.cpp fb31b25
bq. src/examples/python/test_framework.py 0d71831
bq. src/examples/test_executor.cpp ba54004
bq. src/examples/test_framework.cpp 622f6ac
bq. src/java/jni/convert.cpp 5c2bf21
bq. src/java/jni/org_apache_mesos_MesosExecutorDriver.cpp 579ebbe
bq. src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp 547d54b
bq. src/java/src/org/apache/mesos/Scheduler.java b01468b
bq. src/launcher/executor.cpp da4203c
bq. src/master/master.cpp 6110c17
bq. src/messages/messages.proto 7f9cffe
bq. src/python/native/proxy_executor.hpp 32df90b
bq. src/python/native/proxy_executor.cpp d453406
bq. src/python/native/proxy_scheduler.hpp d0e5dfd
bq. src/python/native/proxy_scheduler.cpp 9717f44
bq. src/python/src/mesos.py 25d762b
bq. src/sched/sched.cpp 9440381
bq. src/tests/exception_tests.cpp c14bacc
bq. src/tests/fault_tolerance_tests.cpp 9e7d181
bq. src/tests/master_tests.cpp 57db468
bq. src/tests/resource_offers_tests.cpp a405888
bq. src/tests/utils.hpp 9241567
bq.
bq. Diff: https://reviews.apache.org/r/3083/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. make check
bq.
bq.
bq. Thanks,
bq.
bq. Vinod
bq.
bq.
> Expose master url to the scheduler
> ----------------------------------
>
> Key: MESOS-86
> URL: https://issues.apache.org/jira/browse/MESOS-86
> Project: Mesos
> Issue Type: New Feature
> Reporter: Vinod Kone
> Assignee: Vinod Kone
>
> Introduce new / augment old api calls (callbacks) to expose the master url.
> Currently there is no way for the scheduler to know what the leading master
> is. It would be useful for scheduler's to know this information (e.g:
> pointing to the webui of the leading master). Here is the plan:
> 1) Augment registered() callback to included this info
> 2) Implement new callback re-registered() that gets called whenever a master
> re-election happens. This also contains the new master url.
> 3) Also implement a new callback masterLost() that gets called whenever the
> current master loses election.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
