----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5392/#review8354 -----------------------------------------------------------
src/common/utils.hpp <https://reviews.apache.org/r/5392/#comment18025> Done. src/tests/utils_tests.cpp <https://reviews.apache.org/r/5392/#comment18031> Seems that we don't have an oracle to compare with. I manually tested this both on Mac and Linux. - Jie Yu On June 18, 2012, 6:17 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5392/ > ----------------------------------------------------------- > > (Updated June 18, 2012, 6:17 p.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Description > ------- > > Add utility functions to get runtime system information. > > For example, we can get the kernel version (e.g. version.major.minor), the > operating system name (e.g. Linux, Darwin, etc), and so on. > > These utilities are based the "uname" system call. > > > Diffs > ----- > > src/common/utils.hpp ba55497 > src/tests/utils_tests.cpp 0e3374e > > Diff: https://reviews.apache.org/r/5392/diff/ > > > Testing > ------- > > Tested on Linux and Mac. > > make check > > > Thanks, > > Jie Yu > >
