----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5423/#review8405 -----------------------------------------------------------
Ship it! src/common/logging.cpp <https://reviews.apache.org/r/5423/#comment18064> Any reason not to do: static string argv0 = _argv0; - Benjamin Hindman On June 19, 2012, 8:50 p.m., Charles Reiss wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5423/ > ----------------------------------------------------------- > > (Updated June 19, 2012, 8:50 p.m.) > > > Review request for mesos and Benjamin Hindman. > > > Description > ------- > > InitGoogleLogging() assumes that the const char* (for argv[0]) it is passed > remains valid indefinitely, but the code in common/logging.cpp passes it a > temporary string. This patch uses a static string instead. > > > Diffs > ----- > > src/common/logging.cpp 59ce251 > > Diff: https://reviews.apache.org/r/5423/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Charles Reiss > >
