----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5395/#review9398 -----------------------------------------------------------
Ship it! src/linux/cgroups.cpp <https://reviews.apache.org/r/5395/#comment20127> We've typically called these variables "out" instead of ss. src/linux/cgroups.cpp <https://reviews.apache.org/r/5395/#comment20128> How about instead of making reading an Option, you just discard the future in 'finalize' all the time? It doesn't hurt to call discard (even if the future was never actually associated with anything) and that way you don't have to have the extra '.get()' everywhere or the need to reason about when it's "okay" to call '.get()' because the Option isSome and when it's not. - Benjamin Hindman On July 16, 2012, 6:32 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/5395/ > ----------------------------------------------------------- > > (Updated July 16, 2012, 6:32 p.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Description > ------- > > In cgroups, sometimes you want to be notified if some certain events happen. > For example, users may want to be notified when an out-of-memory event > happens. > > This patch introduce a function called "listenEvent" which returns an > instance of Future so that you can check the status of this future to see > whether any event happens. > > This interface is general to all the events in cgroups. > > > Diffs > ----- > > src/linux/cgroups.hpp cec9e36 > src/linux/cgroups.cpp 93c140f > src/tests/cgroups_tests.cpp 7f0f901 > > Diff: https://reviews.apache.org/r/5395/diff/ > > > Testing > ------- > > On Linux machines, make check. > > > Thanks, > > Jie Yu > >
