----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6146/#review9594 -----------------------------------------------------------
src/exec/exec.cpp <https://reviews.apache.org/r/6146/#comment20462> { on newline. src/exec/exec.cpp <https://reviews.apache.org/r/6146/#comment20463> This isn't needed. src/exec/exec.cpp <https://reviews.apache.org/r/6146/#comment20465> Just override 'initialize' (put it in protected, and don't forget virtual keyword) and put the body of this function in it. src/exec/exec.cpp <https://reviews.apache.org/r/6146/#comment20467> Kill space before semi-colon. src/exec/exec.cpp <https://reviews.apache.org/r/6146/#comment20466> This is more than 80 characters: s/&ShutdownProcess::kill/&Self::kill/ src/exec/exec.cpp <https://reviews.apache.org/r/6146/#comment20468> s/p "/p"/ src/exec/exec.cpp <https://reviews.apache.org/r/6146/#comment20469> s/p "/p"/ src/exec/exec.cpp <https://reviews.apache.org/r/6146/#comment20470> No need for this, just spawn the process and have it get garbaged collected automagically below. src/exec/exec.cpp <https://reviews.apache.org/r/6146/#comment20471> Just do: spawn(new ShutdownProcess(), true); src/exec/exec.cpp <https://reviews.apache.org/r/6146/#comment20472> Same thing here: spawn(new ShutdownProcess(), true); src/exec/exec.cpp <https://reviews.apache.org/r/6146/#comment20473> Kill. src/slave/process_based_isolation_module.cpp <https://reviews.apache.org/r/6146/#comment20474> Not 80 characters. src/slave/process_based_isolation_module.cpp <https://reviews.apache.org/r/6146/#comment20475> Ditto. src/webui/webui.cpp <https://reviews.apache.org/r/6146/#comment20476> Ditto. src/webui/webui.cpp <https://reviews.apache.org/r/6146/#comment20477> Ditto. - Benjamin Hindman On July 28, 2012, 12:46 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6146/ > ----------------------------------------------------------- > > (Updated July 28, 2012, 12:46 a.m.) > > > Review request for mesos, Benjamin Hindman, John Sirois, and Brian Wickman. > > > Description > ------- > > See summary > > > This addresses bug MESOS-244. > https://issues.apache.org/jira/browse/MESOS-244 > > > Diffs > ----- > > src/exec/exec.cpp d60c28d > src/slave/process_based_isolation_module.cpp b54f91c > src/webui/webui.cpp 9453002 > third_party/libprocess/include/stout/os.hpp 1186d24 > > Diff: https://reviews.apache.org/r/6146/diff/ > > > Testing > ------- > > Need more specific tests. > > But 'make check' succeeds. > > > Thanks, > > Vinod Kone > >
