----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6224/#review9625 -----------------------------------------------------------
Ship it! src/common/values.cpp <https://reviews.apache.org/r/6224/#comment20534> Some inner parens would be nice to prevent second-guessing the order of operations. Also, ASCII art would be fantastic - i had to stare at this for a bit to be convinced that it works. Feel free to steal my work below. // b e // current |- - - -| // range |- - - -| // b e // current |- - - -| // range |- - - -| // b e src/common/values.cpp <https://reviews.apache.org/r/6224/#comment20535> this block is repeated 4 times, a helper function would be nice. src/common/values.cpp <https://reviews.apache.org/r/6224/#comment20536> mismatch in indent/wrap style - some places the operator is on the first line, others it's on the continued line - Bill Farner On July 31, 2012, 5:42 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6224/ > ----------------------------------------------------------- > > (Updated July 31, 2012, 5:42 a.m.) > > > Review request for mesos, Benjamin Hindman and John Sirois. > > > Description > ------- > > See summary. > > > This addresses bug MESOS-247. > https://issues.apache.org/jira/browse/MESOS-247 > > > Diffs > ----- > > src/common/values.cpp 0e9dd4f > src/tests/resources_tests.cpp 3e144ed > > Diff: https://reviews.apache.org/r/6224/diff/ > > > Testing > ------- > > make check > > Please let me know any other tests you can think of. Lets fix ranges foreva. > > > Thanks, > > Vinod Kone > >
