----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6704/#review11478 -----------------------------------------------------------
Ship it! Minor comments in addition to comments from last review. src/slave/gc.cpp <https://reviews.apache.org/r/6704/#comment24583> Need a destructor where you loop through all PathInfo objects and discard and delete the Promise<bool>. src/tests/gc_tests.cpp <https://reviews.apache.org/r/6704/#comment24595> Add a TODO to put this in utils.hpp for other peoples consumption. Also, check out the LaunchTasks action to determine if this solves your problem, or if you could modify LaunchTasks to do so (no worries if you don't do anything about it now, just want to educate ourselves so we don't build two different things which do the same thing). - Benjamin Hindman On Sept. 11, 2012, 11:06 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/6704/ > ----------------------------------------------------------- > > (Updated Sept. 11, 2012, 11:06 p.m.) > > > Review request for mesos, Benjamin Hindman, John Sirois, and Ben Mahler. > > > Description > ------- > > Added the ability in the slave to GC executor directories based on the > current disk usage. > > Currently, it uses a very simple algorithm to decide which directories to > delete. > > > This addresses bug MESOS-254. > https://issues.apache.org/jira/browse/MESOS-254 > > > Diffs > ----- > > src/slave/constants.hpp 380a2b9 > src/slave/flags.hpp e99ee8b > src/slave/gc.hpp 3760d09 > src/slave/gc.cpp 5212a41 > src/slave/slave.hpp b7ab2ab > src/slave/slave.cpp 3e2a8d5 > src/tests/gc_tests.cpp bb7416c > third_party/libprocess/include/process/timeout.hpp ce0dea7 > third_party/libprocess/include/stout/duration.hpp e303d2c > third_party/libprocess/include/stout/os.hpp df0f7ff > > Diff: https://reviews.apache.org/r/6704/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
