----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9480/#review16757 -----------------------------------------------------------
include/mesos/mesos.proto <https://reviews.apache.org/r/9480/#comment35614> What about cases where we want to allocate based on 'framework' but not 'user'? i.e.,, can 'user' be optional too? More importantly, do you have any thoughts no how to make this more generic/hierarchical? For example, what if we want to dedicate resources to all users of a team? include/mesos/mesos.proto <https://reviews.apache.org/r/9480/#comment35615> How about calling this Allocation instead of Dedication? Dedication seems to be too strict of a notion, compared to Allocation. src/common/dedications.hpp <https://reviews.apache.org/r/9480/#comment35622> kill new line. src/common/dedications.hpp <https://reviews.apache.org/r/9480/#comment35617> The new style is to put each argument on its own line, indented by 4 spaces. static Dedication parse( const std::string& user, const std::string& framework, const std::string& resources); src/common/dedications.hpp <https://reviews.apache.org/r/9480/#comment35618> new line before this declaration would make it more clear. src/common/dedications.hpp <https://reviews.apache.org/r/9480/#comment35619> kill new line src/common/dedications.cpp <https://reviews.apache.org/r/9480/#comment35621> formatting. see my above comment on formatting multi argument functions/methods. src/common/dedications.cpp <https://reviews.apache.org/r/9480/#comment35624> Make 'framework' and 'resources' of type cosnt Option<string>&. That makes it absolutely clear that they can be optional. src/common/dedications.cpp <https://reviews.apache.org/r/9480/#comment35623> Can 'resources' be an empty string? Is that a valid command line flag? src/slave/flags.hpp <https://reviews.apache.org/r/9480/#comment35620> what does '&' mean? Is that how you separate dedications/allocations? If yes, thats not very clear. Probably an example string in the description makes it more clear. - Vinod Kone On Feb. 16, 2013, 12:52 a.m., Thomas Marshall wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9480/ > ----------------------------------------------------------- > > (Updated Feb. 16, 2013, 12:52 a.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Description > ------- > > Introduces the Dedication abstraction, a protobuf with C++ wrapper in the > style of Attributes or Resources, used to store information about resources > on certain slaves being statically dedicated to certain frameworks/users. The > patch allows this information to be passed in to the slave as a command line > option, then parses it and creates the appropriate Dedication objects to be > passed to the allocator. > > This patch does not implement the logic behind static allocations in the > allocator because I'm trying to break all of this up to make it easier to > review. > > > Diffs > ----- > > include/mesos/mesos.proto 3823515 > src/Makefile.am c94736d > src/common/dedications.hpp PRE-CREATION > src/common/dedications.cpp PRE-CREATION > src/slave/flags.hpp 39e57f4 > src/slave/slave.hpp e9f7b65 > src/slave/slave.cpp 9755b46 > > Diff: https://reviews.apache.org/r/9480/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Thomas Marshall > >
