> On Feb. 22, 2013, 11:23 p.m., Ben Mahler wrote: > > src/slave/cgroups_isolation_module.cpp, line 321 > > <https://reviews.apache.org/r/9408/diff/9/?file=261098#file261098line321> > > > > Can you use a different continuation here? > > > > I see this is why you added the cgroup name and info, but really the > > continuation for this one is really simple (just LOG(INFO)). This will also > > simplify the logic inside _killExecutor.
done. added a _destroy(). > On Feb. 22, 2013, 11:23 p.m., Ben Mahler wrote: > > src/slave/process_based_isolation_module.cpp, line 196 > > <https://reviews.apache.org/r/9408/diff/9/?file=261099#file261099line196> > > > > kill the comment now? good catch. ty. > On Feb. 22, 2013, 11:23 p.m., Ben Mahler wrote: > > src/slave/slave.cpp, line 334 > > <https://reviews.apache.org/r/9408/diff/9/?file=261100#file261100line334> > > > > s/till/until > > > > Can you satisfy the TODO by calling: > > terminate(isolationModule, false) > > > > This will not inject the terminate message in front of the queue, which > > seems like the right thing to do, right? Thats not enough. We need to wait until all the asynchronous cgroup destroys complete. > On Feb. 22, 2013, 11:23 p.m., Ben Mahler wrote: > > src/slave/slave.cpp, line 1097 > > <https://reviews.apache.org/r/9408/diff/9/?file=261100#file261100line1097> > > > > Can you add a TODO where the completedFrameworks is declared in the > > slave header for me to used the Owned abstraction? > > > > (Owned was introduced in the monitoring reviews) done - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9408/#review16974 ----------------------------------------------------------- On Feb. 22, 2013, 2:49 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9408/ > ----------------------------------------------------------- > > (Updated Feb. 22, 2013, 2:49 a.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Description > ------- > > See summary > > > Diffs > ----- > > src/slave/cgroups_isolation_module.hpp > 669efa14ba2603764aa68ae19a44e79dbfdec192 > src/slave/cgroups_isolation_module.cpp > a2eba6f96f5d8a4b1257571aa29e37c5682aab8d > src/slave/process_based_isolation_module.cpp > 12a579cba56cd3dac384bc7919b0d5537b0e429d > src/slave/slave.cpp d4721c3eb51db87278d05f6fbe2eadb8a3a9b4dd > src/tests/balloon_framework_test.sh > 93a733f64cfde08349b7781eb3d5e13594c74498 > > Diff: https://reviews.apache.org/r/9408/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
