----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9794/#review17521 -----------------------------------------------------------
Ship it! src/linux/proc.cpp <https://reviews.apache.org/r/9794/#comment37187> Food for thought: I called it ProcessStatistics because it's reading /proc/[pid]/stat ... but after seeing more how it's being used it's not really "statistics" as much as "status". In fact, 'man 5 proc' even says "contains status information". Maybe we s/ProcessStatistics/ProcessStatus/? src/linux/proc.cpp <https://reviews.apache.org/r/9794/#comment37186> If you pondered s/_pid/pid/ I would not have argued. src/linux/proc.cpp <https://reviews.apache.org/r/9794/#comment37185> You know, you can call this 'children' if you want. ;) src/linux/proc.cpp <https://reviews.apache.org/r/9794/#comment37188> What's your reasoning to put this comment here instead of above the 'descendants' declaration above (or said another way, why declare the descendants alone)? src/linux/proc.cpp <https://reviews.apache.org/r/9794/#comment37184> Why not just pull the parent out first: --------------------------------- pid_t parent = parents.front(); parents.pop(); // Search for children of parent. --------------------------------- The algorithm is unnecessarily complicated by the implicitness of "current process" == parents.front() (and with no extra performance gain). - Benjamin Hindman On March 7, 2013, 3:16 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9794/ > ----------------------------------------------------------- > > (Updated March 7, 2013, 3:16 a.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Description > ------- > > This is used in the following review for process based isolation resource > usage. > > > Diffs > ----- > > src/linux/proc.hpp e0825a4a9f9e2763e0c25d7319f220bfe7c7c29c > src/linux/proc.cpp da30e9a860ba7a142015baf05feaa508bdcdfed5 > src/tests/proc_tests.cpp c3fa526dc2909ad7cb84a3a40c5850885b0065e0 > > Diff: https://reviews.apache.org/r/9794/diff/ > > > Testing > ------- > > Added tests. > > > Thanks, > > Ben Mahler > >
