----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9795/#review17522 -----------------------------------------------------------
src/slave/process_based_isolation_module.cpp <https://reviews.apache.org/r/9795/#comment37194> I don't understand why these are PCHECKs? Maybe if you did this after each of the sysconf's that would make sense. But then I'd probably return a failed future! src/slave/process_based_isolation_module.cpp <https://reviews.apache.org/r/9795/#comment37189> Adding on to a comment in another review, this would then be 'proc::status(info->pid)' which sounds good to me and a /proc/[pid]/status actually exists and is just the prettyfied version of /proc/[pid]/status. src/slave/process_based_isolation_module.cpp <https://reviews.apache.org/r/9795/#comment37190> s/descendant/child/ and s/ancestor/parent/? src/slave/process_based_isolation_module.cpp <https://reviews.apache.org/r/9795/#comment37192> What's the thought behind this formatting? src/slave/process_based_isolation_module.cpp <https://reviews.apache.org/r/9795/#comment37193> If we ever start to integrate some of the monitoring into the webui it would be swell to be able to play with it on our laptops. For that, I suggest some os::shell calls here. See src/scripts/killtree.sh for inspiration (I could even imagine a minor refactor of killtree.sh so you can easily just print all pids in the tree without actually killing them, i.e., by sending them a CONT signal or 0). src/slave/process_based_isolation_module.cpp <https://reviews.apache.org/r/9795/#comment37191> You don't need the 'struct'. - Benjamin Hindman On March 7, 2013, 3:18 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9795/ > ----------------------------------------------------------- > > (Updated March 7, 2013, 3:18 a.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Description > ------- > > See subject. > > > This addresses bug MESOS-370. > https://issues.apache.org/jira/browse/MESOS-370 > > > Diffs > ----- > > src/slave/process_based_isolation_module.cpp > ff98d105af675dfc66070feaa43b42c1aa438fd8 > > Diff: https://reviews.apache.org/r/9795/diff/ > > > Testing > ------- > > make check and added tests in a subsequent review > > > Thanks, > > Ben Mahler > >
