> On April 11, 2013, 8:52 p.m., Vinod Kone wrote: > >
After talking to BenM, I've decided to use switch statements for state checking. I think this makes it much easier to reason about the states of frameworks and executors. Let me know how it looks! > On April 11, 2013, 8:52 p.m., Vinod Kone wrote: > > src/slave/slave.cpp, line 1003 > > <https://reviews.apache.org/r/10142/diff/5/?file=279791#file279791line1003> > > > > checks not needed here. > On April 11, 2013, 8:52 p.m., Vinod Kone wrote: > > src/slave/slave.cpp, lines 1219-1222 > > <https://reviews.apache.org/r/10142/diff/5/?file=279791#file279791line1219> > > > > Verify and change the semantics of how we do SUM.update() w/ and w/o > > checkpoint. I'm going to split the SUM related changes into its own review. > On April 11, 2013, 8:52 p.m., Vinod Kone wrote: > > src/slave/slave.cpp, line 1197 > > <https://reviews.apache.org/r/10142/diff/5/?file=279791#file279791line1197> > > > > check for non null pid actually, since we recover the pid we can't check for non-existence of pid here. this was an existing bug! - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10142/#review19027 ----------------------------------------------------------- On April 9, 2013, 8:58 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10142/ > ----------------------------------------------------------- > > (Updated April 9, 2013, 8:58 p.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Description > ------- > > This is based off https://reviews.apache.org/r/10112. > > Also fixed TODOs and other misc stuff from the above review. > > > Diffs > ----- > > src/slave/isolator.hpp d702041784f5db159efd7da4d916405e86d99741 > src/slave/slave.hpp 2529bf500a3265b10ad4cddde10c2d62a6cdb4a0 > src/slave/slave.cpp 325231458a6883019436e7cc5a37f85f0f5735fa > src/slave/status_update_manager.hpp > e6ca40c5c05c0952cf76fb1db7eff2e4270c0d24 > src/slave/status_update_manager.cpp > 044d245f370ef23ddc67fadbf7f8fe9d75dd662a > src/tests/isolator.hpp f885ccb44e809383e658f45d9a03eda174cf2d72 > > Diff: https://reviews.apache.org/r/10142/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
