----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10891/#review20043 -----------------------------------------------------------
Ship it! third_party/libprocess/include/process/limiter.hpp <https://reviews.apache.org/r/10891/#comment41298> Document the constructor, to be explicit about 'permits' and 'duration'. third_party/libprocess/include/process/limiter.hpp <https://reviews.apache.org/r/10891/#comment41299> Document? third_party/libprocess/include/process/limiter.hpp <https://reviews.apache.org/r/10891/#comment41301> CHECK against permits being 0, and duration being 0? third_party/libprocess/include/process/limiter.hpp <https://reviews.apache.org/r/10891/#comment41300> deque is implying we want the properties of a deque.. isn't queue sufficient? (I know the default container for a queue is a deque, but I think it makes it clearer). third_party/libprocess/src/tests/process_tests.cpp <https://reviews.apache.org/r/10891/#comment41297> Were these LOG(INFO) messages temporary? - Ben Mahler On May 1, 2013, 9:57 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10891/ > ----------------------------------------------------------- > > (Updated May 1, 2013, 9:57 p.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Description > ------- > > BenH's patch. > > > Diffs > ----- > > third_party/libprocess/Makefile.am d9d9110cc75d71642e621097bbc8bdcb88fdc0f8 > third_party/libprocess/include/process/limiter.hpp PRE-CREATION > third_party/libprocess/src/tests/process_tests.cpp > 8fbf19676c54eb0da6f8daa042de127608bcb00b > > Diff: https://reviews.apache.org/r/10891/diff/ > > > Testing > ------- > > sudo ./third_party/libprocess/tests --gtest_filter="*limiter*" --verbose > --gtest_repeat=1000 --gtest_break_on_failure > > > Thanks, > > Vinod Kone > >
