-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11100/#review22217
-----------------------------------------------------------



src/slave/incinerator.hpp
<https://reviews.apache.org/r/11100/#comment45636>

    I like Trash, especially since the name of the folder is .trash.
    
    Maybe later s/GarbageCollector/TrashCollector/? ;)


- Ben Mahler


On June 21, 2013, 12:44 a.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11100/
> -----------------------------------------------------------
> 
> (Updated June 21, 2013, 12:44 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Ben Mahler.
> 
> 
> Description
> -------
> 
> The purpose of the incinerator is to move items to trash and empty trash in 
> rate-limited manner. It is designed to work across slave restarts.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 933743593d8de2fcc412d2f771a4cbc1e6fd2884 
>   src/slave/constants.hpp 901fdf220a902de9241511393530eb19fdfc3244 
>   src/slave/constants.cpp e8d16ca3307249a8b49720eaf8dcb0e7555fca7a 
>   src/slave/incinerator.hpp PRE-CREATION 
>   src/slave/incinerator.cpp PRE-CREATION 
>   src/tests/gc_tests.cpp 174580086370f61be369f7a212d62531e87e6f01 
> 
> Diff: https://reviews.apache.org/r/11100/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Reply via email to