> On June 21, 2013, 12:49 a.m., Jiang Yan Xu wrote: > > 3rdparty/libprocess/include/process/limiter.hpp, line 100 > > <https://reviews.apache.org/r/12018/diff/3/?file=309840#file309840line100> > > > > Rate is an effectively a class constant too but we prefer to compute it > > each time instead of storing it if the computation is cheap enough, right?
thats correct. also, storing permits and duration separately instead of a rate, gives us more flexibility in the future (e.g., ability to obtain bulk permits). - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12018/#review22216 ----------------------------------------------------------- On June 21, 2013, 12:26 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12018/ > ----------------------------------------------------------- > > (Updated June 21, 2013, 12:26 a.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, and Jiang Yan Xu. > > > Description > ------- > > The old review seems to have disappeared into the ether. > > > Diffs > ----- > > 3rdparty/libprocess/Makefile.am 2819734f9d607ba71af6ab98b0d05bd08f67919e > 3rdparty/libprocess/include/process/limiter.hpp PRE-CREATION > 3rdparty/libprocess/src/tests/process_tests.cpp > dfa11df4b5eaa8116d7150feea67bb255d3389de > > Diff: https://reviews.apache.org/r/12018/diff/ > > > Testing > ------- > > sudo GLOG_v=1 ./3rdparty/libprocess/tests --gtest_filter="*limiter*" > --verbose --gtest_repeat=1000 --gtest_break_on_failure > > > Thanks, > > Vinod Kone > >
