On Tue, May 14, 2013 at 09:08:16AM -0400, Sam Nelson wrote: > pciutils provides very basic utilities for > querying the devices on the pci bus, when pci > interface is supported in the platform and > useful to be part of the console package
Sam, This looks very good! Few more nit-picks: 0. Again, the subject line should follow the OE Community guidelines: http://openembedded.org/wiki/Commit_Patch_Message_Guidelines We've discussed it already here: http://arago-project.org/pipermail/meta-arago/2013-May/001373.html 1. If you are re-sending a new revision of the patch, please update the subject to contain [PATCHv2] or [PATCHv3] etc. Also you can log the changes between patch revisions after --- mark. 2. This recipe now becomes machine-specifci, so please add at the top: PACKAGE_ARCH = "${MACHINE_ARCH}" 3. And please don't forget to add "pci" to the list of MACHINE_FEATURES for your machine (keystone-evm.conf) or better yet your SOC (keystone.inc) -- Denys > Signed-off-by: Sam Nelson <[email protected]> > --- > .../packagegroups/packagegroup-arago-console.bb | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git > a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-console.bb > b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-console.bb > index 5a80064..ceee77e 100755 > --- > a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-console.bb > +++ > b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-console.bb > @@ -1,6 +1,6 @@ > DESCRIPTION = "Extended task to get more basic and console apps" > LICENSE = "MIT" > -PR = "r5" > +PR = "r6" > > inherit packagegroup > > @@ -25,6 +25,7 @@ ARAGO_UTILS = "\ > i2c-tools \ > iproute2 \ > strace \ > + ${@base_contains('MACHINE_FEATURES', 'pci', 'pciutils', '',d)} \ > " > > ARAGO_SDK_PREREQ = "\ > -- > 1.7.9.5 > > _______________________________________________ > meta-arago mailing list > [email protected] > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago _______________________________________________ meta-arago mailing list [email protected] http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
