On Tue, Feb 11, 2014 at 12:51:57PM -0500, Sam Nelson wrote:
> - Virtual Tunnels over TCP/IP networks with
>    traffic shaping, compression and encryption

Looks mostly good, just couple comments.


> Signed-off-by: Sam Nelson <[email protected]>
> 
> ---
> Changes from previous patch
> * Updated LIC_FILES_CHECKSUM to use just the copyright lines
> ---
> ---
>  .../recipes-connectivity/vtun/vtun_3.0.3.bb        |   23 
> ++++++++++++++++++++
>  1 file changed, 23 insertions(+)
>  create mode 100755 meta-arago-extras/recipes-connectivity/vtun/vtun_3.0.3.bb
> 
> diff --git a/meta-arago-extras/recipes-connectivity/vtun/vtun_3.0.3.bb 
> b/meta-arago-extras/recipes-connectivity/vtun/vtun_3.0.3.bb
> new file mode 100755
> index 0000000..bb4d69d
> --- /dev/null
> +++ b/meta-arago-extras/recipes-connectivity/vtun/vtun_3.0.3.bb
> @@ -0,0 +1,23 @@
> +DESCRIPTION = "Virtual Tunnels over TCP/IP networks with traffic shaping, 
> compression and encryption."
> +HOMEPAGE = "http://vtun.sourceforge.net/";
> +SECTION = "console/network"
> +PRIORITY = "optional"

Drop PRIORITY please.


> +LICENSE = "GPLv2"
> +DEPENDS = "zlib lzo openssl"
> +PR = "r0"
> +LIC_FILES_CHKSUM = 
> "file://vtun.h;startline=1;endline=17;md5=9ac9e7fefca60c72400239e0de40cde8"
> +
> +SRC_URI = 
> "http://downloads.sourceforge.net/project/vtun/vtun/${PV}/vtun-${PV}.tar.gz";
> +
> +SRC_URI[md5sum] = "f3becf2a0270910a841060c08d1db824"
> +SRC_URI[sha256sum] = 
> "69dcbe4f8c5ce7d91b4150a6309e536d03b61841169746ca5788413ac7edb9cb"
> +
> +inherit autotools
> +
> +do_configure() {
> +     sed -i "s/\$BLOWFISH_HDR_DIR \/usr\/include\/ssl/\$BLOWFISH_HDR_DIR 
> \/usr\/include\/ssl \$SSL_HDR_DIR/" configure
> +     oe_runconf --with-lzo-headers=${STAGING_INCDIR}/lzo 
> --with-lzo-lib=${STAGING_LIBDIR} --with-ssl-headers=${STAGING_INCDIR}/openssl 
> --with-ssl-lib=${STAGING_LIBDIR}
> +     sed '102d' Makefile > Makefile.new
> +     mv Makefile.new Makefile

What's the reason for the above 2 sed commands? A small comment before 
do_configure() explaining why you are doing that, would be great! Thanks.


> +}
> +
> -- 
> 1.7.9.5
> 
> _______________________________________________
> meta-arago mailing list
> [email protected]
> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
_______________________________________________
meta-arago mailing list
[email protected]
http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago

Reply via email to