>-----Original Message-----
>From: Dmytriyenko, Denys
>Sent: Wednesday, June 04, 2014 10:28 AM
>To: Maupin, Chase
>Cc: Cooper Jr., Franklin; [email protected]
>Subject: Re: [meta-arago] [PATCH 06/11] image-gallery: Add image
>gallery application
>
>On Wed, Jun 04, 2014 at 02:38:23PM +0000, Maupin, Chase wrote:
>> >-----Original Message-----
>> >From: [email protected] [mailto:meta-arago-
>> >[email protected]] On Behalf Of Cooper Jr., Franklin
>> >Sent: Thursday, May 29, 2014 1:38 PM
>> >To: [email protected]
>> >Cc: Cooper Jr., Franklin
>> >Subject: [meta-arago] [PATCH 06/11] image-gallery: Add image
>> >gallery application
>> >
>> >* Add new Qt application to the SDK which displays pictures
>taken
>> >by the camera
>> > demo.
>> >
>> >Signed-off-by: Franklin S. Cooper Jr <[email protected]>
>> >---
>> > .../recipes-qt/qt-apps/image-gallery_git.bb | 33
>> >++++++++++++++++++++
>> > 1 files changed, 33 insertions(+), 0 deletions(-)
>> > create mode 100644 meta-arago-extras/recipes-qt/qt-apps/image-
>> >gallery_git.bb
>> >
>> >diff --git a/meta-arago-extras/recipes-qt/qt-apps/image-
>> >gallery_git.bb b/meta-arago-extras/recipes-qt/qt-apps/image-
>> >gallery_git.bb
>> >new file mode 100644
>> >index 0000000..3040415
>> >--- /dev/null
>> >+++ b/meta-arago-extras/recipes-qt/qt-apps/image-gallery_git.bb
>> >@@ -0,0 +1,33 @@
>> >+DESCRIPTION = "Image Gallery"
>> >+HOMEPAGE = "https://gitorious.org/image-gallery";
>> >+SECTION = "multimedia"
>> >+LICENSE = "BSD"
>> >+LIC_FILES_CHKSUM =
>> >"file://LICENSE;md5=9c57cc1cdee589f97cbba69e95a89a15"
>> >+
>> >+require recipes-core/matrix/matrix-gui-paths.inc
>> >+
>> >+PR = "r0"
>>
>> Not needed
>
>Why? Even though it's default, it helps remember to bump it next
>time :)
True, but I thought as we look at new releases the PR wasn't needed anymore.
Or do we not have the version server turned on?
>
>
>> >+BRANCH = "master"
>> >+SRCREV = "8901d7c598b277e4e26a5abbcb859e7ceebd340a"
>> >+
>> >+SRC_URI = "git://gitorious.org/image-gallery/image-
>> >gallery.git;protocol=git;branch=${BRANCH}"
>> >+
>> >+S = "${WORKDIR}/git/"
>> >+
>> >+BUILDDIR ?= "."
>>
>> I'm not entirely sure what this is for. When should this be set
>> differently? And would it be better to use a variable like ${S}
>rather than
>> "."
>
>I have seen this variable in qt-tstat recipe and had to remove it.
>There is no
>need for it and moreover, there's already ${B} defined and used
>for build dir.
>See my recent patch re-submission for qt-tstat.
>
>
>> >+inherit qt-provider
>> >+
>> >+do_install() {
>> >+ install -d ${D}/usr/bin
>>
>> Use ${bindir}
>
>+1
>
>
>> >+ install -m 0755 ${BUILDDIR}/image-gallery
>> >${D}/usr/bin/image-gallery
>>
>> Use ${bindir}
>
>+1
>
>
>> >+ install -d ${D}${MATRIX_APP_DIR}/qt-image-gallery
>> >+ cp -rf matrix-files/* ${D}${MATRIX_APP_DIR}/qt-image-
>> >gallery
>> >+}
>> >+
>> >+PACKAGES += "matrix-gui-apps-image-gallery"
>> >+
>> >+RDEPENDS_matrix-gui-apps-image-gallery = "matrix-gui-apps-
>images
>> >matrix-gui-submenus-camera ${PN}"
>> >+
>> >+FILES_matrix-gui-apps-image-gallery += "${MATRIX_APP_DIR}/*"
>> >--
>> >1.7.0.4
>> >
>> >_______________________________________________
>> >meta-arago mailing list
>> >[email protected]
>> >http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
>> _______________________________________________
>> meta-arago mailing list
>> [email protected]
>> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
_______________________________________________
meta-arago mailing list
[email protected]
http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
