On Thu, Oct 7, 2021 at 11:37 PM Denys Dmytriyenko <de...@denix.org> wrote:
>
> On Thu, Oct 07, 2021 at 07:39:39PM +0530, Sinthu Raja wrote:
> > From: Sinthu Raja <sinthu.r...@ti.com>
> >
> > The Intel 9260 WiFi and BT firmware is already part of the linux-firmware
> > repository.
> >
> > Signed-off-by: Sinthu Raja <sinthu.r...@ti.com>
> > ---
> >  .../linux-firmware/linux-firmware_%.bbappend       | 14 +++++++++++++-
> >  1 file changed, 13 insertions(+), 1 deletion(-)
> >
> > diff --git 
> > a/meta-arago-distro/recipes-kernel/linux-firmware/linux-firmware_%.bbappend 
> > b/meta-arago-distro/recipes-kernel/linux-firmware/linux-firmware_%.bbappend
> > index 146596ad..2e2ab1c4 100644
> > --- 
> > a/meta-arago-distro/recipes-kernel/linux-firmware/linux-firmware_%.bbappend
> > +++ 
> > b/meta-arago-distro/recipes-kernel/linux-firmware/linux-firmware_%.bbappend
> > @@ -1,4 +1,16 @@
> > -PR_append = ".arago0"
> > +PR_append = ".arago1"
> > +
> > +PACKAGES_prepend_j7-evm =+ "${PN}-iwlwifi-9260"
> > +PACKAGES_prepend_j7-evm =+ "${PN}-ibt-18"
>
> Two issues here:
>
> 1. use either _prepend or =+ but not both
Hi Denys,
I found an issue that _prepend is not working and throwing error
during parsing the recipes, below is the error
Nothing RPROVIDES 'linux-firmware-iwlwifi-9260'

But when adding only '=+', it is able to parse the recipe. So, I will
resend the patch with the updated code.

Regards,
Sinthu Raja.

> 2. making machine-specific changes to only PACKAGES isn't right for several
> reasons - should probably be a generic change
>
>
> > +LICENSE_${PN}-iwlwifi-9260 =+ "Firmware-iwlwifi_firmware"
> > +LICENSE_${PN}-ibt-18 =+ "Firmware-ibt_firmware"
> > +
> > +FILES_${PN}-iwlwifi-9260 =+ 
> > "${nonarch_base_libdir}/firmware/iwlwifi-9260-*.ucode"
> > +FILES_${PN}-ibt-18 =+ "${nonarch_base_libdir}/firmware/intel/ibt-18-*.sfi 
> > ${nonarch_base_libdir}/firmware/intel/ibt-18-*.ddc"
> > +
> > +RDEPENDS_${PN}-iwlwifi-9260 =+ "${PN}-iwlwifi-license"
> > +RDEPENDS_${PN}-ibt-18 =+ "${PN}-ibt-license"
> >
> >  do_install_append() {
> >       rm -rf  ${D}/lib/firmware/ti-connectivity/
> > --
> > 2.31.1
>
> --
> Regards,
> Denys Dmytriyenko <de...@denix.org>
> PGP: 0x420902729A92C964 - 
> https://linkprotect.cudasvc.com/url?a=https%3a%2f%2fdenix.org%2f0x420902729A92C964&c=E,1,bXXjzFvGHF13INNI8BKX6juPjLQrOPW9-ZxDN4gqRWkhMo1q_9SNPfUCY7Cf798WISv_G27z34807TS7mfHoi31ZICc0w1k8GnYY-k_vhkiS3JM,&typo=1
> Fingerprint: 25FC E4A5 8A72 2F69 1186  6D76 4209 0272 9A92 C964



-- 
With Regards
Sinthu Raja
_______________________________________________
meta-arago mailing list
meta-arago@arago-project.org
http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago

Reply via email to