Hello Max, On Tue, Mar 31, 2015 at 7:55 AM, Max Krummenacher <[email protected]> wrote: > 2015-03-31 3:16 GMT+02:00 Otavio Salvador <[email protected]>: >>> diff --git a/classes/fsl-dynamic-packagearch.bbclass >>> b/classes/fsl-dynamic-packagearch.bbclass >>> index 40eae6c..498053f 100644 >>> --- a/classes/fsl-dynamic-packagearch.bbclass >>> +++ b/classes/fsl-dynamic-packagearch.bbclass >>> @@ -16,7 +16,7 @@ >>> # >>> # To use the class, specify, for example: >>> # >>> -# MACHINE_SOCARCH_soc = "${TUNE_PKGARCH}-soc" >>> +# MACHINE_SOCARCH_SUFFIX_soc = "-soc" >>> # >>> # and the need filters, as: >>> # >>> @@ -45,3 +45,10 @@ python __anonymous () { >>> bb.debug(1, "Use '%s' as package archictecture for '%s'" % >>> (package_arch, PN)) >>> d.setVar("PACKAGE_ARCH", package_arch) >>> } >>> + >>> + >>> +ARM_EXTRA_SOCARCH = >>> "${ARMPKGARCH}${ARMPKGSFX_DSP}${ARMPKGSFX_EABI}${ARMPKGSFX_ENDIAN}${ARMPKGSFX_FPU}${MACHINE_SOCARCH_SUFFIX}" >>> +THUMB_EXTRA_SOCARCH = >>> "${ARMPKGARCH}${ARM_THUMB_SUFFIX}${ARMPKGSFX_DSP}${ARMPKGSFX_EABI}${ARMPKGSFX_ENDIAN}${ARMPKGSFX_FPU}${MACHINE_SOCARCH_SUFFIX}" >>> +MACHINE_SOCARCH = "${@bb.utils.contains('ARM_INSTRUCTION_SET', 'thumb', >>> '${THUMB_EXTRA_SOCARCH}', '${ARM_EXTRA_SOCARCH}', d)}" >>> +PACKAGE_EXTRA_ARCHS_append = " ${@bb.utils.contains('TUNE_FEATURES', >>> 'arm', '${ARM_EXTRA_SOCARCH}', '', d) }" >>> +PACKAGE_EXTRA_ARCHS_append = " ${@bb.utils.contains('TUNE_FEATURES', >>> 'thumb', '${THUMB_EXTRA_SOCARCH}', '', d) }" >> >> You can use a: >> >> PACKAGE_EXTRA_ARCHS_append = " ${MACHINE_SOCARCH}" >> >> here. So it makes a easier to read code :-) >> >> If you agree with that, I can do the change while applying it here or >> you can send a v5 if you prefer. Both way works :-) > If I understand you correctly, that is you want to replace both > 'PACKAGE_EXTRA_ARCHS_append' with one using MACHINE_SOCARCH then I > don't agree. > > The point of the patch is that a package recipe will put it's output > into MACHINE_SOCARCH which can be either the arm or the thumb feed. > That recipe will not need PACKAGE_EXTRA_ARCHS at all. > Then the image recipe must have both, the arm and the thumb feed in > PACKAGE_EXTRA_ARCHS to find all packages. The image recipe will not > use MACHINE_SOCARCH. > > Thus I set MACHINE_SOCARCH depending on the setting of > ARM_INSTRUCTION_SET so a package goes to the feed designated for the > used instruction set for the package recipe's use. > And I add both possible feed names to PACKAGE_EXTRA_ARCHS for rootfs creation.
I have missed this. I just reordered the very end of file. Now this looks like: http://privatepaste.com/a0d29826e6 Pushed to master-next for a build test. -- Otavio Salvador O.S. Systems http://www.ossystems.com.br http://code.ossystems.com.br Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750 -- _______________________________________________ meta-freescale mailing list [email protected] https://lists.yoctoproject.org/listinfo/meta-freescale
