On 8 July 2014 08:00, <wei.sern.c...@intel.com> wrote: > +# Recipe Ingredients (source, patch, etc) > +# Package Run-time dependency
No need to add comments explaining what variables are for. > +S = "${WORKDIR}/dpdk-${PV}" This is the default, remove it. > +export INSTALL_PATH = "/opt/dpdk" Why does DPDK get installed into /opt, and why can't it be fully installed into ${prefix}? > +do_compile () { > + unset LDFLAGS TARGET_LDFLAGS BUILD_LDFLAGS > + > + cd ${S}/${RTE_TARGET} > + oe_runmake EXTRA_LDFLAGS=" --sysroot=${PKG_CONFIG_SYSROOT_DIR}" \ > + EXTRA_CFLAGS=" --sysroot=${PKG_CONFIG_SYSROOT_DIR}" \ You don't want to use PKG_CONFIG_SYSROOT_DIR, as that's for use by pkg-config. Use $STAGING_DIR_HOST. > +do_compile_append () { Merge do_compile and do_compile_append. > + case `basename ${app}` in > + "dpdk_qat") continue > + ;; > + "vhost") continue > + ;; > + "vhost_xen") continue > + ;; > + esac That's a lot of code for a simple test. Using | will let you do multiple tests in a single case, or just use test. > + ################################################################# > + ### Creating necessary folder under "image" directory > + ### Those folders are to host compiled binary, scripts, > + ### libraries. > + ################################################################# No need to explain something obvious, every do_install has to make the directories it installs into. > +do_install_append () { Merge do_install and do_install_append. > + #Install test applications > + #Install example applications More comments for obvious code. > +# Split the DPDK ingredient into several packages defined by PACKAGES. > +# Please refer to ${WORKDIR}/packages-split/ > +# Note: DPDK ingredient only goes into one of the split package > +# Note: For kernel module built from DPDK, please don't include > +# them in the following package as they go into kernel-module-* split > +# package Remove obvious comments. > +FILES_${PN}-dbg += " \ > + ${INSTALL_PATH}/.debug \ > + ${INSTALL_PATH}/doc \ > + ${INSTALL_PATH}/${RTE_TARGET}/app/.debug \ > + " Copy-paste error, putting documentation into the -dbg package? > +FILES_${PN}-dev += " \ > + ${INSTALL_PATH}/${RTE_TARGET}/.config \ > + ${includedir} \ > + ${includedir}/arch \ > + ${includedir}/exec-env \ > + " > + > +FILES_${PN} += " ${INSTALL_PATH}/${RTE_TARGET}/app/ \ > + /lib64/ \ > + ${INSTALL_PATH}/tools \ > + " Hard-coded /lib64? > +FILES_${PN}-staticdev += "${libdir}/*.a" This is the default, remove. Ross -- _______________________________________________ meta-intel mailing list meta-intel@yoctoproject.org https://lists.yoctoproject.org/listinfo/meta-intel