Review +1, Thanks to address my comment > On Feb 9, 2017, at 11:17 AM, Todor Minchev <todor.minc...@linux.intel.com> > wrote: > > By default make will output the commands that are executed for each > target. Silent mode can be enabled with the '-s' option. > > Example: > make -s > > Signed-off-by: Todor Minchev <todor.minc...@linux.intel.com> > --- > Makefile | 21 +++++++++++---------- > Makefile.efi | 10 +++++----- > 2 files changed, 16 insertions(+), 15 deletions(-) > > diff --git a/Makefile b/Makefile > index 9ade775..c58047a 100644 > --- a/Makefile > +++ b/Makefile > @@ -25,23 +25,24 @@ RMC_CFLAGS := -Wall -I$(TOPDIR)/inc > all: rmc > > $(ALL_OBJS): %.o: %.c > - @$(CC) -c $(CFLAGS) $(RMC_CFLAGS) $< -o $@ > + $(CC) -c $(CFLAGS) $(RMC_CFLAGS) $< -o $@ > > librmc: $(RMC_LIB_OBJ) > - @$(AR) rcs src/lib/$@.a $^ > + $(AR) rcs src/lib/$@.a $^ > > rmc: $(RMC_TOOL_OBJ) librmc > - @$(CC) $(CFLAGS) $(RMC_CFLAGS) -Lsrc/lib/ -lrmc $(RMC_TOOL_OBJ) > src/lib/librmc.a -o src/$@ > + $(CC) $(CFLAGS) $(RMC_CFLAGS) -Lsrc/lib/ -lrmc $(RMC_TOOL_OBJ) \ > + src/lib/librmc.a -o src/$@ > > clean: > - @rm -f $(ALL_OBJS) src/rmc src/lib/librmc.a > + rm -f $(ALL_OBJS) src/rmc src/lib/librmc.a > > .PHONY: clean rmc librmc > > install: > - @mkdir -p $(RMC_INSTALL_BIN_PATH) > - @install -m 755 src/rmc $(RMC_INSTALL_BIN_PATH) > - @mkdir -p $(RMC_INSTALL_LIB_PATH) > - @install -m 644 src/lib/librmc.a $(RMC_INSTALL_LIB_PATH) > - @mkdir -p $(RMC_INSTALL_HEADER_PATH) > - @install -m 644 $(RMC_INSTALL_HEADERS) $(RMC_INSTALL_HEADER_PATH) > + mkdir -p $(RMC_INSTALL_BIN_PATH) > + install -m 755 src/rmc $(RMC_INSTALL_BIN_PATH) > + mkdir -p $(RMC_INSTALL_LIB_PATH) > + install -m 644 src/lib/librmc.a $(RMC_INSTALL_LIB_PATH) > + mkdir -p $(RMC_INSTALL_HEADER_PATH) > + install -m 644 $(RMC_INSTALL_HEADERS) $(RMC_INSTALL_HEADER_PATH) > diff --git a/Makefile.efi b/Makefile.efi > index 3bd417d..66081d7 100644 > --- a/Makefile.efi > +++ b/Makefile.efi > @@ -18,16 +18,16 @@ RMC_CFLAGS := -DRMC_EFI -Wall -I$(TOPDIR)/inc -fpic > -nostdinc -nostdlib -fno-bu > all: librmcefi > > $(RMC_LIB_OBJ): %.efi.o: %.c > - @$(CC) -c $(CFLAGS) $(RMC_CFLAGS) $< -o $@ > + $(CC) -c $(CFLAGS) $(RMC_CFLAGS) $< -o $@ > > librmcefi: $(RMC_LIB_OBJ) > - @$(AR) rcs src/lib/$@.a $^ > + $(AR) rcs src/lib/$@.a $^ > > clean: > - @rm -f $(RMC_LIB_OBJ) src/lib/librmcefi.a > + rm -f $(RMC_LIB_OBJ) src/lib/librmcefi.a > > .PHONY: clean librmcefi > > install: > - @mkdir -p $(RMC_INSTALL_LIB_PATH) > - @install -m 644 $(RMC_INSTALL_LIBS) $(RMC_INSTALL_LIB_PATH) > + mkdir -p $(RMC_INSTALL_LIB_PATH) > + install -m 644 $(RMC_INSTALL_LIBS) $(RMC_INSTALL_LIB_PATH) > -- > 2.11.1 >
-- _______________________________________________ meta-intel mailing list meta-intel@yoctoproject.org https://lists.yoctoproject.org/listinfo/meta-intel
