Thanks for the feedback. v2 has been sent. Assuming no other issues are
found I'll merge tomorrow. Apologies for the delays.
Thanks,
Cal
On 04/01/2018 10:37 PM, Belal, Awais wrote:
+PACKAGECONFIG[libnuma] = ",,libnuma"
This dependency should be on 'numactl' which is provided under meta-oe and the
PACKAGECONFIG should use just numa rather than libnuma IMO.
BR,
Awais
________________________________________
From: California Sullivan <california.l.sulli...@intel.com>
Sent: Saturday, March 31, 2018 2:29 AM
To: meta-intel@yoctoproject.org
Cc: kexin....@windriver.com; Belal, Awais; California Sullivan
Subject: [meta-dpdk][PATCH] dpdk.inc: fix missing numa.h by disabling NUMA
options by default
Otherwise we get this:
| dpdk-18.02/lib/librte_eal/linuxapp/eal/eal_memory.c:27:10: fatal error:
numa.h: No such file or directory
| #include <numa.h>
| ^~~~~~~~
| compilation terminated.
Signed-off-by: California Sullivan <california.l.sulli...@intel.com>
---
Based on top of Awais's patch "dpdk: upgrade to 18.02"
recipes-extended/dpdk/dpdk.inc | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/recipes-extended/dpdk/dpdk.inc b/recipes-extended/dpdk/dpdk.inc
index ce4e8bc..9affda4 100644
--- a/recipes-extended/dpdk/dpdk.inc
+++ b/recipes-extended/dpdk/dpdk.inc
@@ -29,10 +29,12 @@ COMPATIBLE_HOST_libc-musl_class-target = "null"
PACKAGECONFIG[dpdk_qat] = ",,virtual/qat"
PACKAGECONFIG[vhost] = ",,fuse"
PACKAGECONFIG[libvirt] = ",,libvirt"
+PACKAGECONFIG[libnuma] = ",,libnuma"
export CONFIG_EXAMPLE_DPDK_QAT = "${@bb.utils.contains('PACKAGECONFIG',
'dpdk_qat', 'y', 'n', d)}"
export CONFIG_EXAMPLE_VM_POWER_MANAGER = "${@bb.utils.contains('PACKAGECONFIG',
'libvirt', 'y', 'n', d)}"
export CONFIG_VHOST_ENABLED = "${@bb.utils.contains('PACKAGECONFIG', 'vhost', 'y',
'n', d)}"
+export CONFIG_VHOST_NUMA_ENABLED = "${@bb.utils.contains('PACKAGECONFIG',
'libnuma', 'y', 'n', d)}"
RDEPENDS_${PN} += "python-subprocess virtual/libibverbs"
DEPENDS = "virtual/kernel virtual/libibverbs"
@@ -80,6 +82,8 @@ do_configure () {
sed -e
"s#CONFIG_RTE_KNI_VHOST=n#CONFIG_RTE_KNI_VHOST=${CONFIG_VHOST_ENABLED}#" -i
${S}/config/common_linuxapp
sed -e
"s#CONFIG_RTE_KNI_VHOST_VNET_HDR_EN=n#CONFIG_RTE_KNI_VHOST_VNET_HDR_EN=${CONFIG_VHOST_ENABLED}#"
-i ${S}/config/common_linuxapp
sed -e
"s#CONFIG_RTE_LIBRTE_VHOST=n#CONFIG_RTE_LIBRTE_VHOST=${CONFIG_VHOST_ENABLED}#"
-i ${S}/config/common_linuxapp
+ sed -e
"s#CONFIG_RTE_LIBRTE_VHOST_NUMA=.*#CONFIG_RTE_LIBRTE_VHOST_NUMA=${CONFIG_VHOST_NUMA_ENABLED}#"
-i ${S}/config/common_linuxapp
+ sed -e
"s#CONFIG_RTE_EAL_NUMA_AWARE_HUGEPAGES=.*#CONFIG_RTE_EAL_NUMA_AWARE_HUGEPAGES=${CONFIG_VHOST_NUMA_ENABLED}#"
-i ${S}/config/common_linuxapp
make O=$RTE_TARGET T=$RTE_TARGET config
}
--
2.14.3
--
_______________________________________________
meta-intel mailing list
meta-intel@yoctoproject.org
https://lists.yoctoproject.org/listinfo/meta-intel