>-----Original Message----- >From: [email protected] [mailto:meta-ti- >[email protected]] On Behalf Of Vishwanathrao Badarkhe, >Manish >Sent: Friday, June 28, 2013 6:21 AM >To: Hingolikar, Mrinmayee; [email protected] >Subject: Re: [meta-ti] [PATCH] gbm: Add TI staging tree > >Hi, > >On Fri, Jun 28, 2013 at 16:37:51, Hingolikar, Mrinmayee wrote: >> >> Signed-off-by: Mrinmayee Hingolikar <[email protected]> >> --- >> recipes-graphics/gbm/libgbm.inc | 15 +++++++++++++++ >> recipes-graphics/gbm/libgbm_git.bb | 7 +++++++ > >There is no commit message for this patch. > >> 2 files changed, 22 insertions(+), 0 deletions(-) create mode >100644 recipes-graphics/gbm/libgbm.inc create mode 100644 >recipes-graphics/gbm/libgbm_git.bb >> >> diff --git a/recipes-graphics/gbm/libgbm.inc b/recipes- >graphics/gbm/libgbm.inc new file mode 100644 index >0000000..07591e6 >> --- /dev/null >> +++ b/recipes-graphics/gbm/libgbm.inc >> @@ -0,0 +1,15 @@ >> +SUMMARY = "Userspace interface for the kernel GBM services." >> +DESCRIPTION = "This is the gbm frontend used by (for example) >weston \ >> +compositor to load the GLES stack, and retrieve the backing >buffer \ >> +objects behind an eglImage (created with >EGL_WAYLAND_BUFFER_WL), etc.\ >> +The frontend is really just a backend loader and shim. \ The >backend >> +library must be provided by the GLES implementation."
This description looks more like the commit message :) I would shorten this and use comments for more detail as well as adding a commit message. >> +HOMEPAGE = "http://git.ti.com" >> +LICENSE = "MIT" >> +LIC_FILES_CHKSUM = >"file://gbm.c;beginline=1;endline=26;md5=b871c7f2f477df29ee4c0ec43 >7b187f7" >> +PROVIDES = "gbm" I'm not sure why you are setting this. Does something DEPEND on gbm? Also, what is the difference between this and the libgbm package in the mesa-common.inc file? I worry that there is some potential conflict between your package and the libgbm in the mesa recipes. >> + >> +inherit autotools pkgconfig >> + >> +PACKAGES =+ "${PN}-dev" >> +FILES_${PN}-dev = "${libdir}/libgbm_*.so.*" >> diff --git a/recipes-graphics/gbm/libgbm_git.bb b/recipes- >graphics/gbm/libgbm_git.bb >> new file mode 100644 >> index 0000000..d1fa38d >> --- /dev/null >> +++ b/recipes-graphics/gbm/libgbm_git.bb >> @@ -0,0 +1,7 @@ >> +require libgbm.inc >> + >> +SRC_URI = "git://git.ti.com/glsdk/libgbm.git;protocol=git" >> + >> +S = "${WORKDIR}/git" >> + >> +SRCREV = "cb86a2f2cecd41023bf1bf12fbcf11be11220f31" >> -- >> 1.7.0.4 >> >> _______________________________________________ >> meta-ti mailing list >> [email protected] >> https://lists.yoctoproject.org/listinfo/meta-ti >> > > >Regards, >Manish >_______________________________________________ >meta-ti mailing list >[email protected] >https://lists.yoctoproject.org/listinfo/meta-ti _______________________________________________ meta-ti mailing list [email protected] https://lists.yoctoproject.org/listinfo/meta-ti
