Mrinmayee, Ping. Do you have an ETA for addressing the comments below? Thanks.
On Wed, Aug 21, 2013 at 11:49:54AM -0400, Denys Dmytriyenko wrote: > On Wed, Aug 21, 2013 at 03:31:42PM +0000, Maupin, Chase wrote: > > >-----Original Message----- > > >From: [email protected] [mailto:meta-ti- > > >[email protected]] On Behalf Of Hingolikar, Mrinmayee > > >Sent: Wednesday, August 21, 2013 6:48 AM > > >To: Hingolikar, Mrinmayee; [email protected] > > >Subject: Re: [meta-ti] [PATCHv2] abefw: Firmware for OMAP5 ABE > > > > > >Ping for comments! > > > > For some reason I don't see this in my e-mails for the original post. > > Sorry > > for the delay. > > You are correct - there were no v2 submissions to the list on July 3rd. We > only reviewed the original patch before. > > > > >> -----Original Message----- > > >> From: Hingolikar, Mrinmayee > > >> Sent: Wednesday, July 03, 2013 4:32 PM > > >> To: [email protected] > > >> Cc: Hingolikar, Mrinmayee; Heroor, Siddharth > > >> Subject: [PATCHv2] abefw: Firmware for OMAP5 ABE > > >> > > >> * The OMAP5 Audio Backend requires a 'firmware' to enable > > >> sound. This recipe installs a prebuilt firmware. This > > >> part is a hack, as in the current form, the firmware > > >> cannot be cross-compiled. There is a plan to fix this > > >> and hopefully, this recipe is short-lived. Once the code > > >> is fixed, we should have new recipes that build the firmware > > >> and clean up this recipe. > > >> > > >> v2: > > >> * Merged contents from abefw.inc and removed abefw.inc based > > >> on review. > > >> > > >> Signed-off-by: Mrinmayee Hingolikar <[email protected]> > > >> Signed-off-by: Siddharth Heroor <[email protected]> > > >> --- > > >> recipes-bsp/abefw/abefw_1.0.14.bb | 20 ++++++++++++++++++++ > > >> 1 files changed, 20 insertions(+), 0 deletions(-) create mode > > >100644 > > >> recipes-bsp/abefw/abefw_1.0.14.bb > > >> > > >> diff --git a/recipes-bsp/abefw/abefw_1.0.14.bb b/recipes- > > >> bsp/abefw/abefw_1.0.14.bb > > >> new file mode 100644 > > >> index 0000000..8db71e4 > > >> --- /dev/null > > >> +++ b/recipes-bsp/abefw/abefw_1.0.14.bb > > >> @@ -0,0 +1,20 @@ > > >> +SUMMARY = "Firmware for OMAP5 ABE" > > >> +HOMEPAGE = "http://git.ti.com"; > > >> +LICENSE = "BSD/GPLv2" > > > > This seems wrong. I thought the convention is "BSD | GPLv2" for either > > license or "BSD & GPLv2" if mixed license. > > > > If it is mixed then you probably need 2 entries in LIC_FILES_CHKSUM, one > > for > > each license. > > > > Also, does the GPLv2 use the "or later" clause such that it should be > > GPLv2+ > > ? > > This was already mentioned in one of the other patches. > > > > >> +LIC_FILES_CHKSUM = > > >> "file://COPYING;md5=923db086ed9463ab3215b24d87e05ec5" > > >> + > > >> +PACKAGE_ARCH = "${MACHINE_ARCH}" > > >> +COMPATIBLE_MACHINE = "omap5-evm" > > >> + > > >> +SRC_URI = "git://git.ti.com/glsdk/abefw- > > >omap4plus.git;protocol=git" > > The git repo itself says omap4plus - why is it limited to OMAP5 only? Can it > be enabled for OMAP4/Pandaboard too? > > > > Not strictly required but PR = r0 here would help remind you to bump the PR > > in the future. > > > > >> + > > >> +S = "${WORKDIR}/git" > > >> + > > >> +SRCREV = "ceccc0332264e39bdc51e54f80ea7256a3886c58" > > >> + > > >> +do_install() { > > >> + mkdir -p ${D}/lib/firmware > > >> + cp ${S}/firmware/omap4_abe_new ${D}/lib/firmware/ } > > >> + > > >> +FILES_${PN} += "/lib/firmware/omap4_abe_new" > > > > I'm sure this has been discussed before, but do you see any confusion about > > this being omap5-evm only and yet the FW is omap4_abe_new? > > > > >> -- > > >> 1.7.0.4 > > > > > >_______________________________________________ > > >meta-ti mailing list > > >[email protected] > > >https://lists.yoctoproject.org/listinfo/meta-ti > > _______________________________________________ > > meta-ti mailing list > > [email protected] > > https://lists.yoctoproject.org/listinfo/meta-ti > _______________________________________________ > meta-ti mailing list > [email protected] > https://lists.yoctoproject.org/listinfo/meta-ti _______________________________________________ meta-ti mailing list [email protected] https://lists.yoctoproject.org/listinfo/meta-ti
