Hello Bruce,
Thanks for your review!
Here are my answers:
I think we can still hold off on that, but it would be nice to put a comment
above LAYERRECOMMENDS_virtualization-layer to indicate that this
package also required meta-webserver
What is for sure is that there is an hard dependency to cockpit package,
cockpit-machines cannot work on its own. I added a comment for now in
the layer.conf file to mention this dependency.
The next question is: can you put a description of how someone would
test / use the package into the commit message ? Nothing elaborate, but
just something to help me later when I'm potentially upreving it.
Yes! I added some explanation in the commit message. For testing, the
Cockpit URL https://127.0.0.1:9090/machines, from the tested target
should be accessible.
Last question .. the recipe excludes musl (fine with me), but are there
any arch considerations ? I don't think there should be given how it is
configured and built and the description, but if there are, we should just
restrict it up front versus someone asking questions about riscv64 later 🙂
From what I am seeing, there are no arch restrictions. Cockpit and
cockpit-machines are supported on many arch, including risv64. I cannot
test it on this specific arch, but I am seeing that Debian team package
cockpit and cockpit-machines for risv64/all arch (see [1].
Regarding musl compatibility, it is mainly due to the non-compatibility
of systemd with this lib (see [2]), which cockpit depends on.
I pushed the needed modification in the V2 patch.
[1]: https://packages.debian.org/search?keywords=cockpit
[2]:
https://github.com/cockpit-project/cockpit/pull/19513#issuecomment-1774607891
Thanks,
Best regards,
--
Logo Savoir-faire Linux inc.
Paul Le Guen de Kerneizon
Free software consultant | Rennes, France
Logo Jami pleguendekerneizon
On 17/12/2025 14:26, Bruce Ashfield wrote:
On Wed, Dec 17, 2025 at 4:21 AM Paul Le Guen de Kerneizon via
lists.yoctoproject.org
<paul.leguendekerneizon=savoirfairelinux....@lists.yoctoproject.org>
wrote:
Hello community,
Since version 242 of Cockpit package, plugin `cockpit-machines` has been moved
to a dedicated repository. This cockpit plugin is used to manage in web UI
virtual machines. There is currently no support of the new cockpit-machines
package in any Yocto meta and the following patch bring it.
This recipe is suggested to be added in the meta-virtualization in
order to fulfill the needed dependencies on `virt-manager` and
`libvirt-dbus` recipes.
Hi Paul,
Thanks for the contribution!
The recipe itself is simple enough, so no concerns there.
The medium sized question is the dependency on cockpit, which is
maintained in meta-webserver (from the check I just did on the layer
index).
meta-webserver is currently in the layer conf file in the
LAYERRECOMMENDS_virtualization-layer variable (but not mentioned
in the README.md .. I can fix that part though). So we do already have
recipes in meta-virt that need meta-webserver. I'm just pondering whether
adding this bumps it up to LAYERDEPENDS_virtualization-layer.
I think we can still hold off on that, but it would be nice to put a comment
above LAYERRECOMMENDS_virtualization-layer to indicate that this
package also required meta-webserver
The next question is: can you put a description of how someone would
test / use the package into the commit message ? Nothing elaborate, but
just something to help me later when I'm potentially upreving it.
Last question .. the recipe excludes musl (fine with me), but are there
any arch considerations ? I don't think there should be given how it is
configured and built and the description, but if there are, we should just
restrict it up front versus someone asking questions about riscv64 later :)
Cheers,
Bruce
Waiting for your review, feel free to ask any questions or remarks.
Regards,
Paul Le Guen de Kerneizon, Savoir-faire Linux
Paul Le Guen de Kerneizon (1):
cockpit-machines: add recipe
.../cockpit-machines/cockpit-machines_346.bb | 30 +++++++++++++++++++
1 file changed, 30 insertions(+)
create mode 100644 recipes-extended/cockpit-machines/cockpit-machines_346.bb
--
2.34.1
--
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II
--
Logo Savoir-faire Linux inc.
Paul Le Guen de Kerneizon
Free software consultant | Rennes, France
Logo Jami pleguendekerneizon
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#9493):
https://lists.yoctoproject.org/g/meta-virtualization/message/9493
Mute This Topic: https://lists.yoctoproject.org/mt/116824038/21656
Group Owner: [email protected]
Unsubscribe: https://lists.yoctoproject.org/g/meta-virtualization/unsub
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
