On Wed, Apr 10, 2013 at 9:12 AM, Purcareata Bogdan-B43198 <[email protected]> wrote: > Hello, > > The patch makes a modification to the LXC busybox template - the one that > creates a minimal container with Busybox. > > This container will start the udhcpc service - the DHCP client - on init. For > an embedded Linux image, can we assume that most containers will have manual > / static networking configuration on start? If so, starting the udhcpc > service by default is useless, since the service will then have to be killed. > If there are still containers that use DHCP for networking, they can start > udhcpc after container boot. > > The patch deactivates default start of the DHCP client on a Busybox container > init.
This definitely explains the logic, and does belong in an amended long log for the change. Because at some point someone will wonder why. I don't disagree with the reasoning, but it would be nice to have this as an optional change. Since this is a patch, the options for doing it cleanly are limited. So with a cleaned up long log, let's merge this as is after you resend, and we'll see about making it optional if it causes a problem. Cheers, Bruce > > Best regards, > Bogdan P. > > >> -----Original Message----- >> From: Bruce Ashfield [mailto:[email protected]] >> Sent: Wednesday, April 10, 2013 3:55 PM >> To: Purcareata Bogdan-B43198 >> Cc: [email protected] >> Subject: Re: [meta-virtualization] [PATCH] Add disable udhcp patch to LXC >> recipe >> >> Can we get a long log here ? Why would we need to do this, and when ? What >> is this trying to fix ? This is unconditionally applied, so it will >> always be off .. that >> alone warrants and explanation in the long log. >> >> Bruce >> >> On Wed, Apr 10, 2013 at 7:19 AM, Bogdan Purcareata >> <[email protected]> wrote: >> > Signed-off-by: Bogdan Purcareata <[email protected]> >> > --- >> > ...0.9.0-disable-udhcp-from-busybox-template.patch | 24 >> > ++++++++++++++++++++++ >> > recipes-containers/lxc/lxc_0.9.0.bb | 1 + >> > 2 files changed, 25 insertions(+) >> > create mode 100644 >> > recipes-containers/lxc/files/lxc-0.9.0-disable-udhcp-from-busybox-template.patch >> > >> > diff --git >> > a/recipes-containers/lxc/files/lxc-0.9.0-disable-udhcp-from-busybox-template.patch >> b/recipes-containers/lxc/files/lxc-0.9.0-disable-udhcp-from-busybox-template.patch >> > new file mode 100644 >> > index 0000000..723be27 >> > --- /dev/null >> > +++ >> > b/recipes-containers/lxc/files/lxc-0.9.0-disable-udhcp-from-busybox-template.patch >> > @@ -0,0 +1,24 @@ >> > +From d7e07e7acb1cbad33806f49143a2a30b4468c369 Mon Sep 17 00:00:00 2001 >> > +From: Bogdan Purcareata <[email protected]> >> > +Date: Mon, 8 Apr 2013 18:30:19 +0300 >> > +Subject: [PATCH] lxc-0.9.0-disable-udhcp-from-busybox-template >> > + >> > +--- >> > + templates/lxc-busybox.in | 1 - >> > + 1 file changed, 1 deletion(-) >> > + >> > +diff --git a/templates/lxc-busybox.in b/templates/lxc-busybox.in >> > +index cb425ec..bb8c951 100644 >> > +--- a/templates/lxc-busybox.in >> > ++++ b/templates/lxc-busybox.in >> > +@@ -84,7 +84,6 @@ EOF >> > + #!/bin/sh >> > + /bin/syslogd >> > + /bin/mount -a >> > +-/bin/udhcpc >> > + EOF >> > + >> > + # executable >> > +-- >> > +1.7.11.7 >> > + >> > diff --git a/recipes-containers/lxc/lxc_0.9.0.bb >> > b/recipes-containers/lxc/lxc_0.9.0.bb >> > index 292285d..1d6ce71 100644 >> > --- a/recipes-containers/lxc/lxc_0.9.0.bb >> > +++ b/recipes-containers/lxc/lxc_0.9.0.bb >> > @@ -22,6 +22,7 @@ RDEPENDS_${PN} = " \ >> > " >> > >> > SRC_URI = "http://lxc.sourceforge.net/download/lxc/${PN}-${PV}.tar.gz \ >> > + file://lxc-0.9.0-disable-udhcp-from-busybox-template.patch \ >> > " >> > SRC_URI[md5sum] = "8552a4479090616f4bc04d8473765fc9" >> > SRC_URI[sha256sum] = >> > "1e1767eae6cc5fbf892c0e193d25da420ba19f2db203716c38f7cdea3b654120" >> > -- >> > 1.7.11.7 >> > >> > >> > _______________________________________________ >> > meta-virtualization mailing list >> > [email protected] >> > https://lists.yoctoproject.org/listinfo/meta-virtualization >> >> >> >> -- >> "Thou shalt not follow the NULL pointer, for chaos and madness await >> thee at its end" > > -- "Thou shalt not follow the NULL pointer, for chaos and madness await thee at its end" _______________________________________________ meta-virtualization mailing list [email protected] https://lists.yoctoproject.org/listinfo/meta-virtualization
