PV defaults to part of the FILE name

ESW_VER defaults to the same part of the FILE name

Both are intended to be overriden independently by the recipe, if necessary.
So remove the default value as it will already work as intended and avoid
future confusion.

Also cleanup the comment to explain why the remove is necessary.

Signed-off-by: Mark Hatle <[email protected]>
---
 .../classes-recipe/esw.bbclass                            | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/meta-xilinx-standalone-experimental/classes-recipe/esw.bbclass 
b/meta-xilinx-standalone-experimental/classes-recipe/esw.bbclass
index a299fc9c..7d0a2e5d 100644
--- a/meta-xilinx-standalone-experimental/classes-recipe/esw.bbclass
+++ b/meta-xilinx-standalone-experimental/classes-recipe/esw.bbclass
@@ -1,9 +1,9 @@
-PV = "${ESW_VER}"
-
 inherit python3native xlnx-embeddedsw pkgconfig cmake
 
-# It is unclear why the following is needed, but without this cmake/ninja
-# will generate: -isystem /usr/include which will cause a build failure.
+# Poky always tries to enable EXPORT_COMPILE_COMMANDS, but ESW changes
+# behavior when this is enabled and will generate:
+#    -isystem /usr/include
+# which will cause a build failures.
 OECMAKE_ARGS:remove = "-DCMAKE_EXPORT_COMPILE_COMMANDS:BOOL=ON"
 
 SRCREV_FORMAT = "src_decouple"
-- 
2.34.1

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#5374): 
https://lists.yoctoproject.org/g/meta-xilinx/message/5374
Mute This Topic: https://lists.yoctoproject.org/mt/106609958/21656
Group Owner: [email protected]
Unsubscribe: https://lists.yoctoproject.org/g/meta-xilinx/unsub 
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to