Hi Nathan, > -----Original Message----- > From: Nathan Rossi [mailto:nat...@nathanrossi.com] > Sent: Thursday, April 19, 2018 5:04 AM > To: Manjukumar Harthikote Matha <manju...@xilinx.com> > Cc: meta-xilinx@yoctoproject.org; Jeegar Patel <jeeg...@xilinx.com>; Devarsh > Thakkar <devar...@xilinx.com> > Subject: Re: [meta-xilinx] [meta-xilinx-bsp][PATCH] > recipes-multimedia/vcu/*.bb: > Introduce hwcodec and required firmware, ko and software libraries for VCU > > On 14 April 2018 at 06:20, Manjukumar Matha <manjukumar.harthikote- > ma...@xilinx.com> wrote: > > From: Devarsh Thakkar <devar...@xilinx.com> > > > > Add new recipes for the following: > > > > vcu-firmware_git.bb: Add a new recipe to fetch the required firmware > > binaries for VCU > > > > kernel-module-vcu_git.bb: Add new recipe for out-of-tree kernel module > > required for VCU decoder, encoder. This is applicable to MPSoC EV > > devices which support Video Codec Unit > > > > libvcu-xlnx_git.bb: Add a new recipe for control software libraries, > > test applications and headers for VCU > > > > libomxil-xlnx_git.bb: Add VCU hwcodec, this contain the OpenMAX > > libraries, test applications and headers for VCU > > > > Signed-off-by: Devarsh Thakkar <devar...@xilinx.com> > > Signed-off-by: Jeegar Patel <jeegar.pa...@xilinx.com> > > Tested-by: Maulik Desai <maulik.de...@xilinx.com> > > Acked-by: Varunkumar Allagadapa <varun...@xilinx.com> > > Reviewed-by: Bhargava Sreekantappa Gayathri > > <bhargava.sreekantappa-gayat...@xilinx.com> > > Signed-off-by: Manjukumar Matha > > <manjukumar.harthikote-ma...@xilinx.com> > > --- > > .../vcu/kernel-module-vcu_git.bb | 26 +++++++++++++ > > .../recipes-multimedia/vcu/libomxil-xlnx_git.bb | 45 > > ++++++++++++++++++++++ > > .../recipes-multimedia/vcu/libvcu-xlnx_git.bb | 37 ++++++++++++++++++ > > .../recipes-multimedia/vcu/vcu-firmware_git.bb | 37 ++++++++++++++++++ > > 4 files changed, 145 insertions(+) > > create mode 100644 > > meta-xilinx-bsp/recipes-multimedia/vcu/kernel-module-vcu_git.bb > > create mode 100644 > > meta-xilinx-bsp/recipes-multimedia/vcu/libomxil-xlnx_git.bb > > create mode 100644 > > meta-xilinx-bsp/recipes-multimedia/vcu/libvcu-xlnx_git.bb > > create mode 100644 > > meta-xilinx-bsp/recipes-multimedia/vcu/vcu-firmware_git.bb > > > > diff --git > > a/meta-xilinx-bsp/recipes-multimedia/vcu/kernel-module-vcu_git.bb > > b/meta-xilinx-bsp/recipes-multimedia/vcu/kernel-module-vcu_git.bb > > new file mode 100644 > > index 0000000..cfd99d9 > > --- /dev/null > > +++ b/meta-xilinx-bsp/recipes-multimedia/vcu/kernel-module-vcu_git.bb > > @@ -0,0 +1,26 @@ > > +SUMMARY = "Linux kernel module for Video Code Unit" > > +DESCRIPTION = "Out-of-tree VCU decoder, encoder and common kernel > modules provider for MPSoC EV devices" > > +SECTION = "kernel/modules" > > +LICENSE = "GPLv2" > > +LIC_FILES_CHKSUM = > "file://LICENSE.md;md5=eb723b61539feef013de476e68b5c50a" > > + > > +XILINX_VCU_VERSION = "1.0.0" > > +PV = "${XILINX_VCU_VERSION}" > > + > > +S = "${WORKDIR}/git" > > + > > +BRANCH ?= "master" > > Same comment as with the v2018.1 updates, avoid setting the branch unless it > is > specifically needed. > > > +REPO ?= "git://github.com/xilinx/vcu-modules.git;protocol=https" > > +SRCREV ?= "646185390cc1850969c0fa3db59fc8f0e511922e" > > So I noticed most of these repos have the standard Xilinx release versioning, > e.g. > xilinx-v201... tags. Should these recipes follow the same convention as the > other > Xilinx trees? e.g. <recipename>_2018.1.bb and have the PV = > "${XILINX_VCU_VERSION}-xilinx-${XILINX_RELEASE_VERSION}" (or just > "${XILINX_RELEASE_VERSION}"). >
The more I think about it, it is better to stick with recipes saying _git.bb and having PV = "${XILINX_VCU_VERSION} -xilinx-${XILINX_RELEASE_VERSION}+git${SRCPV}". This also follows upstream nomenclature of having recipes which use git as _git.bb I am also planning to change other recipes as well, no reason to deviate from upstream. Thanks, Manju -- _______________________________________________ meta-xilinx mailing list meta-xilinx@yoctoproject.org https://lists.yoctoproject.org/listinfo/meta-xilinx