Hi JFD, On Tue, 2019-07-09 at 11:07:03 -0700, Jean-Francois Dagenais wrote: > > > > On Jul 9, 2019, at 12:59, Hyun Kwon <hyun.k...@xilinx.com> wrote: > > > > > > The Kconfig takes care of it by selecting CONFIG_DMA_SHARED_BUFFER because > > I didn't want to add #ifdefs for downstream changes. > > Ok. But what if someone has no use for DMABUF and doesn't want the extra code > weight, but does want UIO? I.e. a dmabuf-less UIO module? I mean, UIO exists > without all these functions. Automatically adding all this code to the module, > although it would not bother me all that much, might upset some. > > Cheers!
Yes, I understand points you made. But for that, I may end up adding another uio dmabuf config and adding several #ifdefs or even making it as a completely separate module. It seemed overkill to me for a couple of hundred lines of code. I wanted to keep it simple and less intrusive. Maybe I was being lazy. :-) Thanks, -hyun -- _______________________________________________ meta-xilinx mailing list meta-xilinx@yoctoproject.org https://lists.yoctoproject.org/listinfo/meta-xilinx