Fixes: 738c4a65719e ("www: various help text updates")
---
On a related note, there's this comment in LeiXSearch.pm:312:

  # this should really be rt: (received-time), but no stable
  # public-inbox releases support it, yet.
  my $dt = 'dt:'.strftime('%Y%m%d%H%M%S', gmtime($lr)).'..';

So I went all "hey, it's been 3 releases with rt:, let's do this",
and suddenly, `lei up` stopped getting any updates :-]

The problem is that the date syntax handling for d:, dt: and rt: is not
the same (date_parse_prepare in Search.pm), which doesn't seem ideal to
me, either, but maybe that's intentional/necessary?

On a totally unrelated note, this patch is a nice example of how
--diff-algorithm=histogram (which I use by default) sometimes produces
diffs that are both longer and more confusing than with any other
(git-provided) algorithm:

 our $ENQ_ASCENDING = 1;
 our @MAIL_VMAP = (
        [ YYYYMMDD, 'd:'],
-       [ DT, 'dt:' ],
-       # these are undocumented for WWW, but lei and IMAP use them
-       [ BYTES, 'z:' ],
        [ TS, 'rt:' ],
+       # these are undocumented for WWW, but lei and IMAP use them
+       [ DT, 'dt:' ],
+       [ BYTES, 'z:' ],
        [ UID, 'uid:' ]
 );
 our @MAIL_NRP;

 lib/PublicInbox/Search.pm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/PublicInbox/Search.pm b/lib/PublicInbox/Search.pm
index d7a6f9d7913c..477f77dcffeb 100644
--- a/lib/PublicInbox/Search.pm
+++ b/lib/PublicInbox/Search.pm
@@ -68,10 +68,10 @@ our $ENQ_DESCENDING = 0;
 our $ENQ_ASCENDING = 1;
 our @MAIL_VMAP = (
        [ YYYYMMDD, 'd:'],
-       [ DT, 'dt:' ],
+       [ TS, 'rt:' ],
        # these are undocumented for WWW, but lei and IMAP use them
+       [ DT, 'dt:' ],
        [ BYTES, 'z:' ],
-       [ TS, 'rt:' ],
        [ UID, 'uid:' ]
 );
 our @MAIL_NRP;
-- 
2.42.0


Reply via email to