We already stash the associated FD for reporting at startup and don't need to call `fileno' again. Found via manual code inspection while considering the effort to make async {forward} from PublicInbox::HTTP more like the generic long_response API and {long_cb} field used by IMAP/NNTP/POP3. --- lib/PublicInbox/DS.pm | 1 - 1 file changed, 1 deletion(-)
diff --git a/lib/PublicInbox/DS.pm b/lib/PublicInbox/DS.pm index 4c8b502f..8bc8cfb7 100644 --- a/lib/PublicInbox/DS.pm +++ b/lib/PublicInbox/DS.pm @@ -629,7 +629,6 @@ sub long_step { delete $self->{long_cb}; $self->long_response_done; my $elapsed = now() - $t0; - my $fd = fileno($self->{sock}); $self->out(" deferred[$fd] done - %0.6f", $elapsed); my $wbuf = $self->{wbuf}; # do NOT autovivify requeue($self) unless $wbuf && @$wbuf;