On 4/11/2024 3:42 PM, Konstantin Ryabitsev wrote:
> On Thu, Apr 11, 2024 at 03:32:43PM -0700, Jacob Keller wrote:
>> I sometimes download patch series off of public inbox hosted servers to
>> apply with git-am. Occasionally I have found that these do not apply
>> cleanly because the thread is not sorted in patch order.
> 
> It's more than just the order -- if there are replies in the thread, the mbox
> file won't apply either.
> 

If the order was correct, it is usually easy enough to just "git am
--skip" the patches which have no content. However...

> This is the reason why the b4 tool exists:
> https://b4.docs.kernel.org/
> 

This is extremely useful and I was unaware of its existence. Thanks!!

>> For an example, see
>> https://lore.kernel.org/lkml/20240308230557.805580-1-alex.william...@redhat.com/
> 
>     $ b4 am -o/tmp 
> https://lore.kernel.org/lkml/20240308230557.805580-1-alex.william...@redhat.com/
>     Grabbing thread from 
> lore.kernel.org/all/20240308230557.805580-1-alex.william...@redhat.com/t.mbox.gz
>     Analyzing 20 messages in the thread
>     Looking for additional code-review trailers on lore.kernel.org
>     Checking attestation on all messages, may take a moment...
>     ---
>       ✓ [PATCH v2 1/7] vfio/pci: Disable auto-enable of exclusive INTx IRQ
>       ✓ [PATCH v2 2/7] vfio/pci: Lock external INTx masking ops
>         + Reviewed-by: Eric Auger <eric.au...@redhat.com> (✓ DKIM/redhat.com)
>       ✓ [PATCH v2 3/7] vfio: Introduce interface to flush virqfd inject 
> workqueue
>         + Reviewed-by: Eric Auger <eric.au...@redhat.com> (✓ DKIM/redhat.com)
>       ✓ [PATCH v2 4/7] vfio/pci: Create persistent INTx handler
>         + Reviewed-by: Eric Auger <eric.au...@redhat.com> (✓ DKIM/redhat.com)
>       ✓ [PATCH v2 5/7] vfio/platform: Disable virqfds on cleanup
>         + Reviewed-by: Kevin Tian <kevin.t...@intel.com> (✓ DKIM/intel.com)
>         + Reviewed-by: Eric Auger <eric.au...@redhat.com> (✓ DKIM/redhat.com)
>       ✓ [PATCH v2 6/7] vfio/platform: Create persistent IRQ handlers
>         + Reviewed-by: Kevin Tian <kevin.t...@intel.com> (✓ DKIM/intel.com)
>         + Reviewed-by: Eric Auger <eric.au...@redhat.com> (✓ DKIM/redhat.com)
>         + Tested-by: Eric Auger <eric.au...@redhat.com> (✓ DKIM/redhat.com)
>       ✓ [PATCH v2 7/7] vfio/fsl-mc: Block calling interrupt handler without 
> trigger
>         + Reviewed-by: Kevin Tian <kevin.t...@intel.com> (✓ DKIM/intel.com)
>         + Reviewed-by: Eric Auger <eric.au...@redhat.com> (✓ DKIM/redhat.com)
>       ---
>       ✓ Signed: DKIM/redhat.com
>     ---
>     Total patches: 7
>     ---
>     Cover: 
> /tmp/v2_20240308_alex_williamson_vfio_interrupt_eventfd_hardening.cover
>      Link: 
> https://lore.kernel.org/r/20240308230557.805580-1-alex.william...@redhat.com
>      Base: not specified
>            git am 
> /tmp/v2_20240308_alex_williamson_vfio_interrupt_eventfd_hardening.mbx
> 
> -K

Reply via email to