On 11/18/2011 04:00 PM, Esben Almqvist wrote:
Hi all!
I have looked a bit at the code and found something that may be a bug.
The function Initial is run before Coupla. It generates a temperature
profile, dpItp which is used in Coupla and Balanc. Now the temperature
at the beginning of Coupla should be different to the one when Balanc
is run. As far as I can see, dpItp has values from the last
observation. This ok for Balanc, but in Coupla I think it should be at
the starting point of Coupla, i.e. nDeltaTIndice.
So as far as I can see Initial should be run twice. Once for Coupla
and once for Balanc. The following code is used to run Initial in
macadam.c.
330f77name(initial)(dpItp , (dpRTO+1), (dpDTO+1), (dpTAO+1), &nOne, \
331&nLenObservation, &stTemperatureDepth.nSize,\
332&nIR40, &bFlat, npSwo, dpCapacity, dpConductivity);
To run it for Coupla I suggest the following change:
330 f77name(initial)(dpItp , (dpRTO+1), (dpDTO+1), (dpTAO+1), &nOne, \
331
&nDeltaTIndice, &stTemperatureDepth.nSize,\
332&nIR40, &bFlat, npSwo, dpCapacity, dpConductivity);
On row 331 nLenObservation was changed to nDeltaTIndice.
Am I thinking correctly?
Best wishes of a good weekend,
Esben
Hi Esben,
From what I understand, the 'initial' subroutine create the temperature
profile (along the Z axis, from the surface to the ground) at the
beginning of the forecast.
From your explanation, I don't understand why it should be different
for the subroutines 'Coupla' and 'balanc'.
Could you explain in more details the rational behind it?
Thanks and best regards,
Miguel
--
Miguel Tremblay
Développeur METRo - METRo developer
https://gna.org/projects/metro/
Physicien - Physicist
Environnement Canada - Environment Canada
courriel: [email protected]
_______________________________________________
METRo-developers mailing list
[email protected]
https://mail.gna.org/listinfo/metro-developers
