No probs, thanks for taking the time. On Tue, Feb 16, 2016 at 9:04 AM, Stephen McDonald <st...@jupo.org> wrote:
> I've tested and merged all this, thanks as always Alex. > > On Thu, Feb 11, 2016 at 3:06 PM, Alex Hill <a...@hill.net.au> wrote: > >> Yep, currently the dynamic inline classes still remain, as does >> dynamic_inlines.js to facilitate drag-and-drop. It's just that the actual >> manipulation of the DOM on the front-end uses Django's javascript, class >> conventions, etc. >> >> If this goes ahead it will probably be a good idea to rename those things >> for clarity. >> >> Cheers, >> Alex >> >> On Thursday, February 11, 2016 at 7:04:44 AM UTC+8, Stephen McDonald >> wrote: >>> >>> Definitely a good idea if feasible. >>> >>> The only issue that comes to mind is that Mezzanine's inlines are used >>> to support drag/drop ordering, but glancing over the commits it seems like >>> they'll still just work. >>> >>> I'll try and test this soon, but the more people who do, the better, so >>> please try it out too. >>> >>> >>> >>> >>> On Wed, Feb 10, 2016 at 7:08 PM, Alexander Hill <al...@hill.net.au> >>> wrote: >>> >>>> Mezzanine has long used its own mechanism for dynamically adding and >>>> removing inline forms via the "add another" button. I believe this code >>>> originally dates from before Django introduced its own code for this. >>>> >>>> I'm all for getting rid of features in Mezzanine once they exist in >>>> Django itself, and this seems like a prime candidate. Moreover, I think the >>>> grappelli has gradually gone from optional to not-really-optional, and this >>>> is a step towards addressing that. >>>> >>>> Can anyone foresee any problems doing this? Is anybody else interested >>>> in a grappelli-free Mezzanine? >>>> >>>> This change requires modifications to both grappelli-safe and >>>> Mezzanine. If you're interested, please try these branches and let me know >>>> if they work for you: >>>> >>>> https://github.com/stephenmcd/mezzanine/compare/native_dynamic_inlines >>>> >>>> https://github.com/stephenmcd/grappelli-safe/compare/native_dynamic_inlines >>>> >>>> Cheers, >>>> Alex >>>> >>>> -- >>>> You received this message because you are subscribed to the Google >>>> Groups "Mezzanine Users" group. >>>> To unsubscribe from this group and stop receiving emails from it, send >>>> an email to mezzanine-use...@googlegroups.com. >>>> For more options, visit https://groups.google.com/d/optout. >>>> >>> >>> >>> >>> -- >>> Stephen McDonald >>> http://jupo.org >>> >> -- >> You received this message because you are subscribed to the Google Groups >> "Mezzanine Users" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to mezzanine-users+unsubscr...@googlegroups.com. >> For more options, visit https://groups.google.com/d/optout. >> > > > > -- > Stephen McDonald > http://jupo.org > > -- > You received this message because you are subscribed to the Google Groups > "Mezzanine Users" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to mezzanine-users+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "Mezzanine Users" group. To unsubscribe from this group and stop receiving emails from it, send an email to mezzanine-users+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
