On Monday 23 February 2009 00:06:47 Corrado Zoccolo wrote: > On Sun, Feb 22, 2009 at 10:34 PM, Vasily Khoruzhick <[email protected]> wrote: > > On Sunday 22 February 2009 23:24:34 GWater wrote: > > > > > > Just want to note that this patch breaks compatibility with older > > kernels. > > I changed my patch to make it backward compatible using conditional > compilation (attached). > Currently it is tested only on x86-32, on kernels 2.6.28 and 2.6.29-rc4 > > Feedback is welcome. > > Corrado
Looks cool, but it is not style we're using (look at sn9c20x-sysfs.c). The thing is that it will be easy to remove our #ifdefs when we'll prepare driver for including in mainline kernel (it's easy to create script that will do this job). It will be harder to clean up your V4L2_PREFIX and V4L2_ARGS ;) Please use only ifdefs like this one: #if LINUX_VERSION_CODE >= KERNEL_VERSION(2, 6, 29) somecode #endif Regads Vasily
signature.asc
Description: This is a digitally signed message part.
