Hi Brian Agreed, lets block all other commits before this weekend, Guys please post/queue your patches for review this weekend.
Blocking saturation should be simple enuff, maybe commenting http://repo.or.cz/w/microdia.git?a=blob;f=sn9c20x-usb.c;h=4eab2d57558ed87cc0eb788066e4acf97f17d123;hb=0963ed513d4f2abff3469292825f971445402392#l729 Also we need to know which webcams are broken, is it only 6270's ? ('coz i seem to remember some sensor color tweaking here http://repo.or.cz/w/microdia.git?a=commitdiff;h=e22293994c6019579e24d789be203729699306dc ) And hey, its nice to see people are still tracking/testing master/HEAD ;-) We'll arrange for a more through weekend testing this coming friday. -JoJo On Tue, Mar 17, 2009 at 9:28 AM, Brian Johnson <[email protected]> wrote: > > Saturation is supposed to change the intensity of a color so this > patch is not right as well, Also while hue is supposed to change the > actual color this is wrong for that as well since it should not wash > the entire image in a particular color like this patch does. > > I've uploaded for reference an archive containing two data files for > both saturation and hue plus a ruby ruby script that can feed values > from one of the data sources through the debugfs to show a gradual > progression of changing colors. The data values i use for hue and > saturation come from the values used under windows. Run this file > using the following command, where <datafile> is wither hues.yaml or > sats.yaml > # ruby ./color.rb <datafile> > > link: http://groups.google.com/group/microdia/web/color_ref.tar.gz > > My understanding of how the bridge handles hue and saturation is that > you are basically modifying the coefficients for the bridges color > matrix. The color matrix is the set of coefficients used to convert > the RGB data provided by the sensor ot YUV color-space. Saturation > should just be a matter of proper scaling of the matrix values, with > hue involving rotating the values using sin and cos functions. > > The bridge appears to use two bytes per value with the second as far > as i can tell either 0 or f which likly is used tell the sign of the > first byte. > > Since both saturation and hue, as well as contrast and brightness, > play with the values of our color matrix there should really be just > one function that modifies things based on all those values so as to > avoid overwriting what a previous function has done. > > Still since we have yet to get a working version of saturation i still > very much suggest for the time being we revert the current saturation > code and just apply a new patch when someone gets an acceptable patch > for this. > --~--~---------~--~----~------------~-------~--~----~ Lets make microdia webcams plug'n play, (currently plug'n pray) To post to this group, send email to [email protected] Visit us online https://groups.google.com/group/microdia -~----------~----~----~----~------~----~------~--~---
