No magic just went through and split up all lines over 80 characters. There were also a bunch of lines that had doxygen comments following variable names or defines that i removed which nixed a lot of the over 80 character warnings as well.
I've also pushed a patch that fixes up Kconfig and Makefile to allow correct compilation against the latest kernel from git. As of now i can simply drop the files from our source repository into a directory called sn9c20x under drivers/media/video/ and add the appriorate lines to the parent Kconfig and Makefiles under drivers/media/video and i'm able to configure and compile a kernel that includes the sn9c20x driver On Thu, Apr 30, 2009 at 3:51 PM, Josua Grawitter <[email protected]> wrote: > Am Donnerstag 30 April 2009 21:34:27 schrieb Brian Johnson: >> Ok i pushed some patches out that should fix up all the remaining >> issues reported by checkpatch mostly just lines is greater then 80 >> character warnings. There is still one error in sn9c20x.h but it >> really a false positive. >> >> Also quick patch to remove the module param and sysfs code for dealing >> with fps since this was never really implemented and is unused. >> >> >> >> On Thu, Apr 30, 2009 at 2:43 PM, Josua Grawitter >> >> <[email protected]> wrote: >> > I just created a new "prepare-for-kernel" branch in our git repo. >> > >> > As one would expect I want this branch to contain all changes we pushed >> > away because "they will only be done when we go into the kernel". I >> > started with removeing all compatibility for older kernels and the >> > doxygen stuff. >> > >> > Unfortunatly Fedora needs another month to give me a stable way of using >> > 2.6.29 which means I find myself quite unable to test anything from now >> > on. >> > >> > So please test and get everything ready: >> > - Makefile >> > - Kconfig >> > - .config >> > are what comes to mind. >> > >> > Lets get this thing over with. >> > >> > GWater >> >> > > Hey that's great. What kind of magic did you apply to fix all these warnings? > > GWater > --~--~---------~--~----~------------~-------~--~----~ Lets make microdia webcams plug'n play, (currently plug'n pray) To post to this group, send email to [email protected] Visit us online https://groups.google.com/group/microdia -~----------~----~----~----~------~----~------~--~---
